Fix issue on matrix construction over integer mod ring for large coefficients #39488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 11, 2025
sagemathgh-39488: Fix issue on matrix construction over integer mod ring for large coefficients Fix Issue sagemath#36104. In previous versions of Python, `int` size was limited and therefore could be cast to `long`. With Python 3 this limit does not exists and the code breaks with large integers. We modify the construction of `Matrix_modn_dense_template` from Python integers, directly using some existing cast from Sage. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39488 Reported by: Hugo Passe Reviewer(s): Vincent Neiger
|
Please change "Fix Issue #36104" to "Fixes issue #36104" at the start of the PR's description. Then the PR will be linked to the issue, so the issue will be listed under "Successfully merging this pull request may close these issues" at the right of this PR web page. (There will be a similar notation on the PR's web page) Also, the issue will close automatically when the PR is merged. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39488: Fix issue on matrix construction over integer mod ring for large coefficients Fixes sagemath#36104. In previous versions of Python, `int` size was limited and therefore could be cast to `long`. With Python 3 this limit does not exists and the code breaks with large integers. We modify the construction of `Matrix_modn_dense_template` from Python integers, directly using some existing cast from Sage. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39488 Reported by: Hugo Passe Reviewer(s): Vincent Neiger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36104.
In previous versions of Python,
intsize was limited and therefore could be cast tolong. With Python 3 this limit does not exists and the code breaks with large integers. We modify the construction ofMatrix_modn_dense_templatefrom Python integers, directly using some existing cast from Sage.📝 Checklist