Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for checking for old deprecations #39262

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

To find deprecations that can now safely removed.
Example:

python tools/check_deprecations.py src/sage/combinat
Found 9 deprecations.
100%|
Deprecations over one year ago:
File: src\sage\combinat\permutation.py, PR: https://github.com/sagemath/sage/pull/26810, Closed Date: 2019-01-23
File: src\sage\combinat\permutation.py, PR: https://github.com/sagemath/sage/pull/27467, Closed Date: 2019-06-12
File: src\sage\combinat\words\finite_word.py, PR: https://github.com/sagemath/sage/pull/30187, Closed Date: 2020-09-15
File: src\sage\combinat\designs\difference_family.py, PR: https://github.com/sagemath/sage/pull/35211, Closed Date: 2023-04-01

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jan 4, 2025

Documentation preview for this PR (built with commit a387e86; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

interesting. But the delay is one year after the first stable release including the deprecation.

@fchapoton
Copy link
Contributor

Trying that, I installed pygithub using sage-pip install pygithub.
But I could only run once before hitting the "rate limit exceeded" message. And now everything is blocked for several thousand seconds, it seems. Otherwise, pretty useful

to make copy-pasting more easy
@tobiasdiez
Copy link
Contributor Author

tobiasdiez commented Feb 6, 2025

Trying that, I installed pygithub using sage-pip install pygithub. But I could only run once before hitting the "rate limit exceeded" message. And now everything is blocked for several thousand seconds, it seems. Otherwise, pretty useful

Yes, the rate limit is rather low but nothing we can change. Creating a personal API key is also rather straightforward.

So you are happy with this PR? Or should we change the limit to say 15 months to account for the fact that the PR is merged some time before the actual release?

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39461
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39462
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39463
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#39465
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39461
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39462
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39463
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39465
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 10, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39461
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 10, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39462
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 10, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39463
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 10, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39465
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 11, 2025
    
found using the scripts in sagemath#39262

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39454
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants