-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor period lattice #39212
base: develop
Are you sure you want to change the base?
Refactor period lattice #39212
Conversation
Documentation preview for this PR (built with commit 8e5ca6a; changes) is ready! 🎉 |
Check the documentation as well if you already didn't. |
On another note, apparently There are three ways this could be feasibly implemented
but that should not in the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Thanks. (the code introduced by this was one of my first pull requests, and evidently my coding style was not the best back then) |
Improvement for #38474 . (previously I didn't know
is_exact()
exists, thus the uglyisinstance()
check.)Also now it works with RDF and CDF.
📝 Checklist
⌛ Dependencies
Requires #39137 .