Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor period lattice #39212

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Dec 27, 2024

Improvement for #38474 . (previously I didn't know is_exact() exists, thus the ugly isinstance() check.)

Also now it works with RDF and CDF.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Requires #39137 .

Copy link

github-actions bot commented Dec 27, 2024

Documentation preview for this PR (built with commit 8e5ca6a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 10, 2025

Check the documentation as well if you already didn't.

@user202729
Copy link
Contributor Author

On another note, apparently PeriodLattice is also a Parent so it has its own is_exact(), but I decide to not touch this.

There are three ways this could be feasibly implemented

  • always return False — this is because .basis() always return elements in inexact fields;
  • return .curve().is_exact() — (no particularly good reason)
  • throw an error — after all this is more like a facade parent (you can't construct an element with parent() equal to the period lattice)

but that should not in the scope of this PR.

@user202729 user202729 marked this pull request as draft February 10, 2025 02:49
@user202729 user202729 marked this pull request as ready for review February 10, 2025 05:14
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@user202729
Copy link
Contributor Author

Thanks. (the code introduced by this was one of my first pull requests, and evidently my coding style was not the best back then)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants