-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary steps to save the CI infrastructure #39009
Draft
kwankyu
wants to merge
6
commits into
sagemath:develop
Choose a base branch
from
kwankyu:p/add-comments-to-scripts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+209
−344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit 3cfeeca; changes) is ready! 🎉 |
ff6bdcd
to
7da5efe
Compare
db666ee
to
6df7a6a
Compare
user202729
reviewed
Feb 13, 2025
before proceeding it's good to decide whether we rather go with the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
disputed
PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the situation with the CI infrastructure, this PR:
added comments untangling obscure code in CI-related files, for those poor guys who ever attempt to read the files for whatever reasons.
while doing the cosmetic changes, a bug (about
-uninstall
targets) was foundbuild/make/Makefile.in
, which is fixed here.to test, do
fixed some jobs in the CI-linux workflow that fail because of duplicate artifact names.
removed "gentoo" from the list of the default systems that CI runs for. This is how to properly modify the list:
tox.ini
tox -e update_docker_platforms
"optional" and "experimental" jobs now run upon "standard" docker images, instead of "maximal" ones, to avoid "out of runner space" error.
test CI run:
https://github.com/kwankyu/sage/actions/runs/13333439284
📝 Checklist
⌛ Dependencies