Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary steps to save the CI infrastructure #39009

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Nov 20, 2024

To improve the situation with the CI infrastructure, this PR:

  • added comments untangling obscure code in CI-related files, for those poor guys who ever attempt to read the files for whatever reasons.

  • while doing the cosmetic changes, a bug (about -uninstall targets) was found build/make/Makefile.in, which is fixed here.

to test, do

$ ./configure --enable-dot2tex | grep dot2tex
$ make build | grep dot2tex
$ ./configure --disable-dot2tex | grep dot2tex
$ make build | grep dot2tex
  • fixed some jobs in the CI-linux workflow that fail because of duplicate artifact names.

  • removed "gentoo" from the list of the default systems that CI runs for. This is how to properly modify the list:

    • first edit tox.ini
    • run tox -e update_docker_platforms
    • commit the changes
  • "optional" and "experimental" jobs now run upon "standard" docker images, instead of "maximal" ones, to avoid "out of runner space" error.

test CI run:

https://github.com/kwankyu/sage/actions/runs/13333439284

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Add comments untangling complicated code Add comments untangling obscure code in a few build-related files Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Documentation preview for this PR (built with commit 3cfeeca; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu kwankyu force-pushed the p/add-comments-to-scripts branch from ff6bdcd to 7da5efe Compare November 20, 2024 13:47
@kwankyu kwankyu changed the title Add comments untangling obscure code in a few build-related files Add comments untangling obscure code in a few CI-related files Nov 21, 2024
@kwankyu kwankyu force-pushed the p/add-comments-to-scripts branch from db666ee to 6df7a6a Compare February 13, 2025 08:35
@kwankyu kwankyu changed the title Add comments untangling obscure code in a few CI-related files Add comments untangling obscure code in CI-related files Feb 13, 2025
@kwankyu kwankyu changed the title Add comments untangling obscure code in CI-related files Preliminary steps to save the CI infrastructure Feb 13, 2025
@kwankyu kwankyu marked this pull request as ready for review February 13, 2025 10:12
@kwankyu kwankyu mentioned this pull request Feb 13, 2025
5 tasks
@dimpase dimpase added the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Feb 13, 2025
@dimpase
Copy link
Member

dimpase commented Feb 13, 2025

before proceeding it's good to decide whether we rather go with the other PR

@kwankyu kwankyu marked this pull request as draft February 15, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants