Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted changes from #36986 #37850

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

amanmoon
Copy link
Contributor

@amanmoon amanmoon commented Apr 22, 2024

Reverted changes made in #36986

The bug in #36974 remains unsolved. Efforts are being made in #37744 to resolve the bug.

Fixes #37744

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@amanmoon
Copy link
Contributor Author

I am not sure whether the target branch should be develop or master, as this is a reverting PR.

Copy link

github-actions bot commented Apr 22, 2024

Documentation preview for this PR (built with commit 26696ef; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Apr 22, 2024

in all our PRs target is always develop branch

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 23, 2024

@amanmoon Note https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 4, 2024

LGTM.

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 4, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 5, 2024
    
Reverted changes made in sagemath#36986

The bug in sagemath#36974 remains unsolved. Efforts are being made in sagemath#37744 to
resolve the bug.

Fixes  sagemath#37744
### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies
    
URL: sagemath#37850
Reported by: Aman Moon
Reviewer(s):
@vbraun vbraun merged commit eb319c9 into sagemath:develop Jun 9, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#36986 has broken .subgroup(...) badly
4 participants