minor fixes in sandpiles #37410
Merged
minor fixes in sandpiles #37410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Feb 20, 2024
mkoeppe
reviewed
Feb 20, 2024
mkoeppe
approved these changes
Feb 20, 2024
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
|
Documentation preview for this PR (built with commit 73b17c3; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a few
ruffwarnings in the two modified files, plus somepep8code formatting.Also a few code simplifications on the way.
I also changed some errors from
UserWarningto better ones.and changed one function, used nowhere inside sage, into an iterator
📝 Checklist