Remove invariants commands in global namespace #37223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one failing doctest needs to be fixed |
|
New push fixes the doctest by including an import. I'm not sure why |
|
Documentation preview for this PR (built with commit 5453456; changes) is ready! 🎉 |
fchapoton
approved these changes
Feb 5, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
sagemathgh-37223: Remove invariants commands in global namespace This PR removes the depreciated invariants from sagemath#28064 (2019). It's been long enough and we should declutter the tab-autocomplete from these very specific functions. As an aside, I'm not sure why we have: ```py from . import monsky_washnitzer ``` Instead of importing objects from this module, but I have not worked with this myself so am loathed to modify this without further input from the community. URL: sagemath#37223 Reported by: Giacomo Pope Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the depreciated invariants from #28064 (2019). It's been long enough and we should declutter the tab-autocomplete from these very specific functions.
As an aside, I'm not sure why we have:
Instead of importing objects from this module, but I have not worked with this myself so am loathed to modify this without further input from the community.