Fix to ncsym.ncsym.nesting #37218
Merged
Fix to ncsym.ncsym.nesting #37218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to ncsym.ncsym.nesting function.
|
@tscrim can you review this? |
|
Documentation preview for this PR (built with commit 4e0bcf9; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
The nesting function in combinat.ncsym.ncsym.py does not operate as described in its documentation. As intended, it should compare all arcs of two set partitions and count the number of times the second arc nests in the first. As written, there was a break statement caused many (necessary) comparisons to be skipped, particularly for set partitions with large blocks. I have re-written the function so that all necessary comparisons are made. I have also added an example in the docstring that was computed incorrectly by the old code, but is corrected by my fix. This bug is not a previously known issue, and I have also confirmed with the original author (@tscrim ) that no one else is currently working on a fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. ### ⌛ Dependencies No dependencies URL: sagemath#37218 Reported by: lucasgagnon Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nesting function in combinat.ncsym.ncsym.py does not operate as described in its documentation. As intended, it should compare all arcs of two set partitions and count the number of times the second arc nests in the first. As written, there was a break statement caused many (necessary) comparisons to be skipped, particularly for set partitions with large blocks.
I have re-written the function so that all necessary comparisons are made. I have also added an example in the docstring that was computed incorrectly by the old code, but is corrected by my fix.
This bug is not a previously known issue, and I have also confirmed with the original author (@tscrim ) that no one else is currently working on a fix.
📝 Checklist
⌛ Dependencies
No dependencies