sage -t: Fix handling of --probe all broken by #36989
#37177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ada49c to
9c79330
Compare
9c79330 to
d177585
Compare
d177585 to
262f2bd
Compare
|
Thanks, Volker. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 25, 2024
…agemath#36989 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> Broken in 10.3.beta6: ``` ./sage -tp --probe all src/sage/doctest/util.py ... File "/Users/mkoeppe/s/sage/sage-rebasing/worktree- pristine/src/sage/doctest/parsing.py", line 919, in __init__ self.probed_tags = set(probed_tags) ^^^^^^^^^^^^^^^^ TypeError: 'bool' object is not iterable ---------------------------------------------------------------------- sage -t --random-seed=131361480585541724191127226366213696278 src/sage/doctest/util.py # TypeError in doctesting framework ``` <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37177 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 26, 2024
…agemath#36989 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> Broken in 10.3.beta6: ``` ./sage -tp --probe all src/sage/doctest/util.py ... File "/Users/mkoeppe/s/sage/sage-rebasing/worktree- pristine/src/sage/doctest/parsing.py", line 919, in __init__ self.probed_tags = set(probed_tags) ^^^^^^^^^^^^^^^^ TypeError: 'bool' object is not iterable ---------------------------------------------------------------------- sage -t --random-seed=131361480585541724191127226366213696278 src/sage/doctest/util.py # TypeError in doctesting framework ``` <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37177 Reported by: Matthias Köppe Reviewer(s):
|
Documentation preview for this PR (built with commit 262f2bd; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken in 10.3.beta6:
📝 Checklist
⌛ Dependencies