Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor details in asymptotic ring #37105

Merged
merged 1 commit into from
Feb 2, 2024
Merged

minor details in asymptotic ring #37105

merged 1 commit into from
Feb 2, 2024

Conversation

fchapoton
Copy link
Contributor

  • removing doc about empty input
  • adding basic typing annotations
  • some pep8 details

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 9a7f51e; changes) is ready! 🎉

@fchapoton fchapoton requested a review from mezzarobba January 30, 2024 08:26
mezzarobba
mezzarobba approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fchapoton
Copy link
Contributor Author

merci !

@vbraun vbraun merged commit 5c7139e into sagemath:develop Feb 2, 2024
5 checks passed
@fchapoton fchapoton deleted the minor_fixes_asymptotic branch February 3, 2024 08:21
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mezzarobba mezzarobba mezzarobba approved these changes

Assignees
No one assigned
Labels
c: commutative algebra t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @mezzarobba @vbraun @mkoeppe