Fixed .random_element() for fractional ideals in rational quaternion algebras
#37098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
414bed9 to
acdf2c2
Compare
Added QuaternionFractionalIdeal_rational.random_element() to overwrite the ideal.random_element()-method, which doesn't work for fractional ideals; fixed whitespace detected by Lint checks.
acdf2c2 to
22f63e0
Compare
|
Removed the whitespaces in blank lines detected by Lint. |
|
Documentation preview for this PR (built with commit 22f63e0; changes) is ready! 🎉 |
.random_element() for fractional ideals in rational quaternion algebras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
QuaternionFractionalIdeal_rational.random_element()to fix random sampling in fractional ideals of quaternion algebras.The method$\mathbb{Z}$ to return a random $\mathbb{Z}$ -linear combination of the (lattice) generators of the fractional ideal.
.random_element()of the ideal class refers to the ring over which the ideal is defined, but for fractional ideals Sage often (incorrectly) gives the base field of the algebra as a base ring. To work around this, we implement a new functionQuaternionFractionalIdeal_rational.random_element()that hardcodesNote: The deeper issue of separating ideals and fractional ideals still remains - see #3680.
#sd123