src/sage/matrix/matrix_double_dense.pyx: increase an FP tolerance #37043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently hit,
File "src/sage/matrix/matrix_double_dense.pyx", line 1629, in
sage.matrix.matrix_double_dense.Matrix_double_dense.right_eigenvectors
Failed example:
spectrum[3] # tol 1e-13
Expected:
(-1.0, [(1.0, -0.5, 2.0, 0.5)], 1)
Got:
(-1.0000000000000828,
[(1.0, -0.4999999999999238, 1.9999999999997218, 0.4999999999999161)],
1)
Tolerance exceeded in 3 of 6:
-0.5 vs -0.4999999999999238, tolerance 2e-13 > 1e-13
2.0 vs 1.9999999999997218, tolerance 2e-13 > 1e-13
0.5 vs 0.4999999999999161, tolerance 2e-13 > 1e-13
This commit changes that tolerance to 1e-12 and makes the failure go away.
|
Documentation preview for this PR (built with commit 07534a7; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37043: src/sage/matrix/matrix_double_dense.pyx: increase an FP tolerance I recently hit, ``` File "src/sage/matrix/matrix_double_dense.pyx", line 1629, in sage.matrix.matrix_double_dense.Matrix_double_dense.right_eigenvectors Failed example: spectrum[3] # tol 1e-13 Expected: (-1.0, [(1.0, -0.5, 2.0, 0.5)], 1) Got: (-1.0000000000000828, [(1.0, -0.4999999999999238, 1.9999999999997218, 0.4999999999999161)], 1) Tolerance exceeded in 3 of 6: -0.5 vs -0.4999999999999238, tolerance 2e-13 > 1e-13 2.0 vs 1.9999999999997218, tolerance 2e-13 > 1e-13 0.5 vs 0.4999999999999161, tolerance 2e-13 > 1e-13 ``` This commit changes that tolerance to 1e-12 and makes the failure go away. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37043 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37043: src/sage/matrix/matrix_double_dense.pyx: increase an FP tolerance I recently hit, ``` File "src/sage/matrix/matrix_double_dense.pyx", line 1629, in sage.matrix.matrix_double_dense.Matrix_double_dense.right_eigenvectors Failed example: spectrum[3] # tol 1e-13 Expected: (-1.0, [(1.0, -0.5, 2.0, 0.5)], 1) Got: (-1.0000000000000828, [(1.0, -0.4999999999999238, 1.9999999999997218, 0.4999999999999161)], 1) Tolerance exceeded in 3 of 6: -0.5 vs -0.4999999999999238, tolerance 2e-13 > 1e-13 2.0 vs 1.9999999999997218, tolerance 2e-13 > 1e-13 0.5 vs 0.4999999999999161, tolerance 2e-13 > 1e-13 ``` This commit changes that tolerance to 1e-12 and makes the failure go away. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37043 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37043: src/sage/matrix/matrix_double_dense.pyx: increase an FP tolerance I recently hit, ``` File "src/sage/matrix/matrix_double_dense.pyx", line 1629, in sage.matrix.matrix_double_dense.Matrix_double_dense.right_eigenvectors Failed example: spectrum[3] # tol 1e-13 Expected: (-1.0, [(1.0, -0.5, 2.0, 0.5)], 1) Got: (-1.0000000000000828, [(1.0, -0.4999999999999238, 1.9999999999997218, 0.4999999999999161)], 1) Tolerance exceeded in 3 of 6: -0.5 vs -0.4999999999999238, tolerance 2e-13 > 1e-13 2.0 vs 1.9999999999997218, tolerance 2e-13 > 1e-13 0.5 vs 0.4999999999999161, tolerance 2e-13 > 1e-13 ``` This commit changes that tolerance to 1e-12 and makes the failure go away. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37043 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 18, 2024
sagemathgh-37262: Added automatic size labeler I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
sagemathgh-37262: Added automatic size labeler I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 25, 2024
sagemathgh-37262: Added automatic size labeler I have implemented the `automatic size labeler`, which now assigns labels to pull requests based on the number of lines changed **Minimal** Typically involves very small changes, bug fixes, or updates that require only a few lines of code, often less than 50. sagemath#37208 sagemath#37146 sagemath#37043 **Small** Involves more substantial changes than minimal, potentially adding new features or making modifications to existing ones. The range is usually between 50 to 100 lines of code. sagemath#37152 sagemath#37132 **Moderate** Represents a significant portion of the codebase being modified, such as adding new features, refactoring, or making extensive changes to existing functionalities. This might involve between 100 to 300 lines of code. sagemath#36919 sagemath#37112 **Large** Involves substantial and complex changes across various parts of the codebase. This could include major architectural changes, the introduction of new modules, or a significant overhaul of existing features, often exceeding 300 lines of code. sagemath#37125 sagemath#36977 sagemath#36972 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#37254 URL: sagemath#37262 Reported by: Aman Moon Reviewer(s): Sebastian Oehms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently hit,
This commit changes that tolerance to 1e-12 and makes the failure go away.
📝 Checklist
⌛ Dependencies