raise ValueError instead of IndexError in .any_root() #37034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Jan 9, 2024
|
Thanks, done. |
|
Documentation preview for this PR (built with commit d6660cd; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37034: raise ValueError instead of IndexError in .any_root() The `.any_root()` method sometimes raises an `IndexError` instead of the usual `ValueError` when no root exists. Example (Sage 10.2): ```sage sage: R.<x> = Zmod(55)[] sage: (x^2 + 1).any_root() ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[2], line 1 ----> 1 (x**Integer(2)+Integer(1)).any_root() File /usr/lib/python3.11/site- packages/sage/rings/polynomial/polynomial_element.pyx:2315, in sage.rings.polynomial.polynomial_element.Polynomial.any_root (build/cythonized/sage/rings/polynomial/polynomial_element.c:34795)() 2313 return (self//h).any_root(ring, -degree, True) 2314 else: -> 2315 return self.roots(ring=ring, multiplicities=False)[0] 2316 2317 def __truediv__(left, right): IndexError: list index out of range ``` With this patch, we check for the `IndexError` before it happens and raise a `ValueError` instead. URL: sagemath#37034 Reported by: Lorenz Panny Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37034: raise ValueError instead of IndexError in .any_root() The `.any_root()` method sometimes raises an `IndexError` instead of the usual `ValueError` when no root exists. Example (Sage 10.2): ```sage sage: R.<x> = Zmod(55)[] sage: (x^2 + 1).any_root() ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[2], line 1 ----> 1 (x**Integer(2)+Integer(1)).any_root() File /usr/lib/python3.11/site- packages/sage/rings/polynomial/polynomial_element.pyx:2315, in sage.rings.polynomial.polynomial_element.Polynomial.any_root (build/cythonized/sage/rings/polynomial/polynomial_element.c:34795)() 2313 return (self//h).any_root(ring, -degree, True) 2314 else: -> 2315 return self.roots(ring=ring, multiplicities=False)[0] 2316 2317 def __truediv__(left, right): IndexError: list index out of range ``` With this patch, we check for the `IndexError` before it happens and raise a `ValueError` instead. URL: sagemath#37034 Reported by: Lorenz Panny Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-37034: raise ValueError instead of IndexError in .any_root() The `.any_root()` method sometimes raises an `IndexError` instead of the usual `ValueError` when no root exists. Example (Sage 10.2): ```sage sage: R.<x> = Zmod(55)[] sage: (x^2 + 1).any_root() ------------------------------------------------------------------------ --- IndexError Traceback (most recent call last) Cell In[2], line 1 ----> 1 (x**Integer(2)+Integer(1)).any_root() File /usr/lib/python3.11/site- packages/sage/rings/polynomial/polynomial_element.pyx:2315, in sage.rings.polynomial.polynomial_element.Polynomial.any_root (build/cythonized/sage/rings/polynomial/polynomial_element.c:34795)() 2313 return (self//h).any_root(ring, -degree, True) 2314 else: -> 2315 return self.roots(ring=ring, multiplicities=False)[0] 2316 2317 def __truediv__(left, right): IndexError: list index out of range ``` With this patch, we check for the `IndexError` before it happens and raise a `ValueError` instead. URL: sagemath#37034 Reported by: Lorenz Panny Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.any_root()method sometimes raises anIndexErrorinstead of the usualValueErrorwhen no root exists.Example (Sage 10.2):
With this patch, we check for the
IndexErrorbefore it happens and raise aValueErrorinstead.