Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coercion problem with Algebraic Real Field #36942

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Fix coercion problem with Algebraic Real Field #36942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbb3cbe
Simplify the expression before converting it to algebraic number
RuchitJagodara Dec 21, 2023
30b120a
Added a doctest
RuchitJagodara Dec 21, 2023
52a00ba
Corrected a linting error
RuchitJagodara Dec 21, 2023
108470b
Merge remote-tracking branch 'upstream/develop' into develop
RuchitJagodara Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/sage/rings/qqbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,6 +1646,16 @@ def _element_constructor_(self, x):
True
sage: pi in QQbar # needs sage.symbolic
False

TESTS:

Check if :trac:`12745` is fixed::

sage: x = exp(2*I*pi/7) + exp(-2*I*pi/7)
sage: QQbar(x) in AA
True
sage: AA(x)
1.246979603717467?
"""
if isinstance(x, AlgebraicNumber):
return x
Expand Down
2 changes: 1 addition & 1 deletion src/sage/symbolic/expression.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ cdef class Expression(Expression_abc):
0
"""
from sage.symbolic.expression_conversions import algebraic
return algebraic(self, field)
return algebraic(self.simplify_full(), field)

def __hash__(self):
r"""
Expand Down
Loading