-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plant anchors for hunks to create links in doc preview changes #36742
Conversation
At some point it may be a good idea to split out this diff script to a separate file (perhaps in |
Done. Thanks for the idea. |
0cf20e9
to
e1388ba
Compare
Documentation preview for this PR (built with commit 7b0c670; changes) is ready! 🎉 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot! |
The "changes" page of the doc preview of a PR lacks links to the actual changed parts of the doc preview. We plant invisible anchors for each hunk of the diffs and use them to create links to the changed parts. A sample page is
https://deploy-preview-36742--sagemath-tobias.netlify.app/changes
Wishlist item: In the diffsite comparison view, the left pane showing the doc preview is scrolled to the changed part while the right pane showing the base doc does not. It would be nice if the right pane shows the corresponding part. But this cannot be implemented now because the base doc cannot be altered for specific doc preview for a PR.
📝 Checklist
⌛ Dependencies