CI macOS: Build following stages even when some job failed; adjust platforms #36711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the jobs failed
added 2 commits
November 12, 2023 20:11
…tandard by -minimal, to avoid problem with maxima
…void problems with optional conda packages
|
Documentation preview for this PR (built with commit a933ae2; changes) is ready! 🎉 |
|
What are stages 1 and 2? I have a guess about |
|
Stage 1 builds non-Python packages, stage 2 builds Python packages |
jhpalmieri
reviewed
Nov 13, 2023
| @@ -40,30 +40,35 @@ jobs: | |||
| with: | |||
| stage: "2" | |||
| needs: [stage-1] | |||
| if: ${{ success() || failure() }} | |||
There was a problem hiding this comment.
Is this equivalent to if: ${{ always() }}? (I found that at https://docs.github.com/en/actions/using-jobs/using-jobs-in-a-workflow#example-not-requiring-successful-dependent-jobs.) Any reason to prefer one approach to the other?
There was a problem hiding this comment.
We just got rid of a lot of always() in:
|
Okay, looks good. |
jhpalmieri
approved these changes
Nov 13, 2023
|
Thanks! Setting it to blocker so it gets merged in the next rc |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 16, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> sagemath#36711 introduced a syntax error that causes failures: https://github.com/sagemath/sage/actions/runs/6870325982 Fixed here - as seen in https://github.com/mkoeppe/sage/actions/runs/6874334555 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36723 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix what can be seen in https://github.com/sagemath/sage/actions/runs/6827163283 - stage-2 was not attempted because some of the stage-1 jobs failed.
We also replace one of the failing platforms and remove another.
📝 Checklist
⌛ Dependencies