cylint cleanup in combinatorial polyhedra #36623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Nov 1, 2023
| @@ -2793,7 +2790,6 @@ cdef class CombinatorialPolyhedron(SageObject): | |||
| if 'dual' in kwds and dual == -1 and kwds['dual'] in (False, True): | |||
| dual = int(kwds['dual']) | |||
|
|
|||
| cdef FaceIterator face_iter | |||
| if dual == -1: | |||
There was a problem hiding this comment.
Then where is FaceIterator defined? FaceIterator is used below.
There was a problem hiding this comment.
Sorry for noise. It's defined in base.pxd.
|
merge conflict |
|
after a simple rebase, waiting for the checks |
|
Documentation preview for this PR (built with commit 6f8168f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 4, 2023
fixes all cython-lint warnings in combinatorial_polyhedron folder
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36623
Reported by: Frédéric Chapoton
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes all cython-lint warnings in combinatorial_polyhedron folder
📝 Checklist