Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/nauty: Upgrade to 2.8.6, require nauty >= 2.8 #36541

Merged
merged 6 commits into from
Oct 31, 2023
Merged

build/pkgs/nauty: Upgrade to 2.8.6, require nauty >= 2.8 #36541

merged 6 commits into from
Oct 31, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 25, 2023 •
edited
Loading

https://pallini.di.uniroma1.it/changes24-28.txt

Fixes #36257.
Continuation of #36262

We also tighten what versions of system nauty that we accept, because #36257 was motivated by a new feature. This change should also fix failures from accepting ancient versions of system nauty, such as

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Oct 25, 2023
@mkoeppe mkoeppe changed the title build/pkgs/nauty: Upgrade to 2.8.6 build/pkgs/nauty: Upgrade to 2.8.6, require nauty >= 2.8 Oct 25, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2023 

sage -t --random-seed=91672150232460588449403271029502746687 src/sage/graphs/generators/families.py
**********************************************************************
File "src/sage/graphs/generators/families.py", line 3678, in sage.graphs.generators.families.nauty_gentreeg
Failed example:
    [len(list(graphs.nauty_gentreeg(str(i)))) for i in range(1, 15)]
Expected:
    [1, 1, 1, 2, 3, 6, 11, 23, 47, 106, 235, 551, 1301, 3159]
Got:
    [1, 0, 1, 2, 3, 6, 11, 23, 47, 106, 235, 551, 1301, 3159]

@mkoeppe mkoeppe requested a review from dcoudert October 25, 2023 23:15
@dcoudert
Copy link
Contributor

This issue is documented in #35157 (comment)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2023

Thanks! I'll add the patch mentioned there.

@github-actions
Copy link

Documentation preview for this PR (built with commit a95b9d6; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on fedora 35 and all tests pass.

LGTM. Unless if I missed something, we can set to positive review.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2023

Thanks for testing!

@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 26, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
sagemathgh-36541: build/pkgs/nauty: Upgrade to 2.8.6, require nauty…
6a89ad1 
… >= 2.8

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
https://pallini.di.uniroma1.it/changes24-28.txt

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Fixes sagemath#36257.
Continuation of sagemath#36262

We also tighten what versions of system nauty that we accept, because
sagemath#36257 was motivated by a new feature. This change should also fix
failures from accepting ancient versions of system nauty, such as
- `ubuntu-xenial-toolchain-gcc_9` https://github.com/mkoeppe/sage/action
s/runs/6622955701/job/18026345225#step:10:7570 in
src/sage/graphs/digraph_generators.py and other files

<!-- If your change requires a documentation PR, please link it
appropriately. -->

### :memo: Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### :hourglass: Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36541
Reported by: Matthias Köppe
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 29, 2023
sagemathgh-36541: build/pkgs/nauty: Upgrade to 2.8.6, require nauty…
4a23684 
… >= 2.8

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
https://pallini.di.uniroma1.it/changes24-28.txt

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Fixes sagemath#36257.
Continuation of sagemath#36262

We also tighten what versions of system nauty that we accept, because
sagemath#36257 was motivated by a new feature. This change should also fix
failures from accepting ancient versions of system nauty, such as
- `ubuntu-xenial-toolchain-gcc_9` https://github.com/mkoeppe/sage/action
s/runs/6622955701/job/18026345225#step:10:7570 in
src/sage/graphs/digraph_generators.py and other files

<!-- If your change requires a documentation PR, please link it
appropriately. -->

### :memo: Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### :hourglass: Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36541
Reported by: Matthias Köppe
Reviewer(s): David Coudert
@vbraun vbraun merged commit 7c6cda9 into sagemath:develop Oct 31, 2023
@mkoeppe mkoeppe deleted the nauty_2_8_6 branch December 1, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: graph theory c: packages: standard
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

update nauty to version 2.8.6
4 participants
@mkoeppe @dcoudert @vbraun @SouSingh