Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for E702 in pyx outside rings #36420

Merged
merged 3 commits into from
Oct 14, 2023
Merged

fix for E702 in pyx outside rings #36420

merged 3 commits into from
Oct 14, 2023

Conversation

fchapoton
Copy link
Contributor

This fixes pycodestyle warning E702 in pyx files outside of rings

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

dcoudert
dcoudert suggested changes Oct 7, 2023
View reviewed changes
src/sage/groups/perm_gps/partn_ref/refinement_binary.pyx Outdated Show resolved Hide resolved
src/sage/coding/binary_code.pyx Outdated Show resolved Hide resolved
@kwankyu
Copy link
Collaborator

kwankyu commented Oct 8, 2023

Otherwise lgtm.

kwankyu
kwankyu approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vbraun vbraun merged commit a216ed3 into sagemath:develop Oct 14, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 14, 2023
@fchapoton fchapoton deleted the fix_E702_outside_rings branch October 15, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert requested changes

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @kwankyu @dcoudert @vbraun @mkoeppe