-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to the bigraded Betti number methods #36166
Conversation
This should not depend on #35875. Adding the bigraded methods should be done on that PR alone. These PRs are independent AFAICS. I agree with the |
c40e3b7
to
ef87fb7
Compare
e8feeed
to
901b720
Compare
Thank you for the review, @tscrim. I also modified the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merge conflict |
@OP5642 Can you |
7a26b40
to
037b616
Compare
Thank you, I think I managed to do so just now. |
Documentation preview for this PR (built with commit 037b616; changes) is ready! 🎉 |
This pull request expands the functionality of
bigraded_betti_number()
methods of aSimplicialComplex
by adding an additional parameterverbose
. Theverbose
option increases verbosity while computing the invariant by printing the subcomplexes along with their non-trivial homology groups.This PR is a part of #35640 (GSoC 2023).
📝 Checklist