-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.categories
: Update # needs
#35945
Conversation
e94b734
to
65d296e
Compare
65d296e
to
1369d3b
Compare
…combinat[modules]' --only-tags --probe=sage.rings.finite_rings --overwrite
…y-tags --overwrite src/sage/categories/discrete_valuation.py
…y-tags --overwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
…rwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
…ntl' when GF2X is used
…only-tags src/sage/categories/**/*.{py,pyx}
…be all src/sage/categories
6ccda58
to
a9a389e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my best but may have missed some details in this giant PR...
sage: f = lambda part: 2 * s(part.conjugate()) # optional - sage.combinat sage.modules | ||
sage: s._apply_module_endomorphism(s([2,1]) + s([1,1,1]), f) # optional - sage.combinat sage.modules | ||
sage: s = SymmetricFunctions(QQ).schur() # needs sage.combinat sage.modules | ||
sage: f = lambda part: 2 * s(part.conjugate()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s
needs sage.combinat sage.modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a definition of a lambda function, it does not need the binding of s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I have made some improvements to the file in 8b8164d
…misplaced # needs sage.symbolic
…age.rings.finite_rings
…]' --probe sage.combinat
… use sage.combinat
…e more block tags, fix some tags
Documentation preview for this PR (built with commit f29be5a; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to accept this PR. It improves many parts of the code. Further cosmetic improvements can be done in future PRs. This one is already big enough.
LGTM.
Thank you very much! |
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35945 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
📝 Checklist
⌛ Dependencies