Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for GCC < 8.4, drop testing of debian-buster and fedora-29 #35810

Merged
merged 5 commits into from
Aug 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,18 @@ on:
"ubuntu-kinetic",
"ubuntu-lunar",
"ubuntu-mantic",
"debian-buster",
"debian-buster-gcc_spkg",
"debian-bullseye",
"debian-bookworm",
"debian-trixie",
"debian-sid",
"linuxmint-19-gcc_8-python3.8",
"linuxmint-19.3-gcc_8-python3.8",
"linuxmint-20.1",
"linuxmint-20.2",
"linuxmint-20.3",
"linuxmint-21",
"linuxmint-21.1",
"linuxmint-21.2",
"fedora-29-python3.8",
"fedora-30-python3.8",
"fedora-30",
"fedora-31",
"fedora-32",
"fedora-33",
Expand All @@ -59,7 +57,6 @@ on:
"opensuse-tumbleweed-python3.10",
"conda-forge",
"ubuntu-bionic-gcc_8-i386",
"debian-buster-i386",
"debian-bullseye-i386",
]
tox_packages_factors:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ in the Installation Guide.

3. [Linux, WSL] Install the required minimal build prerequisites.

- Compilers: `gcc`, `gfortran`, `g++` (GCC 8.x to 12.x and recent
versions of Clang (LLVM) are supported).
- Compilers: `gcc`, `gfortran`, `g++` (GCC versions from 8.4.0 to 13.x
and recent versions of Clang (LLVM) are supported).
See [build/pkgs/gcc/SPKG.rst](build/pkgs/gcc/SPKG.rst) and
[build/pkgs/gfortran/SPKG.rst](build/pkgs/gfortran/SPKG.rst)
for a discussion of suitable compilers.
Expand Down
4 changes: 2 additions & 2 deletions build/pkgs/gcc/SPKG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Description

This package represents the required C and C++ compilers.

- GCC (GNU Compiler Collection) versions 8.x to 12.x are supported.
- GCC (GNU Compiler Collection) versions 8.x (>= 8.4.0) to 13.x are supported.

- Clang (LLVM) is also supported.

Expand All @@ -25,7 +25,7 @@ need to run::
Vendor and versions of the C and C++ compilers should match.

Users of older Linux distributions (in particular, ``ubuntu-xenial``
or older, ``debian-stretch`` or older, ``linuxmint-18`` or older)
or older, ``debian-buster`` or older, ``linuxmint-18`` or older)
should upgrade their systems before attempting to install Sage from
source. Users of ``ubuntu-bionic``, ``linuxmint-19.x``, and
``opensuse-15.x`` can install a versioned ``gcc`` system package
Expand Down
4 changes: 2 additions & 2 deletions build/pkgs/gcc/spkg-configure.m4
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ SAGE_SPKG_CONFIGURE_BASE([gcc], [
# Add the .0 because Debian/Ubuntu gives version numbers like
# 4.6 instead of 4.6.4 (Trac #18885)
AS_CASE(["$GXX_VERSION.0"],
[[[0-7]].*], [
# Install our own GCC if the system-provided one is older than gcc 8
[[[0-7]].*|8.[[0-3]].*], [
# Install our own GCC if the system-provided one is older than gcc 8.4
SAGE_SHOULD_INSTALL_GCC([you have $CXX version $GXX_VERSION, which is quite old])
],
[1[[4-9]].*], [
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ setenv =
debian-bullseye: BASE_TAG=bullseye
debian-bullseye: IGNORE_MISSING_SYSTEM_PACKAGES=yes
debian-bookworm: BASE_TAG=bookworm
debian-trixie: BASE_TAG=trixie
debian-sid: BASE_TAG=sid
#
# https://hub.docker.com/u/linuxmintd
Expand Down