add .basis_matrix() wrapper to quaternion orders #35767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7d68cf to
53b776f
Compare
|
Documentation preview for this PR (built with commit 53b776f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
Computing the basis matrix of a quaternion order is a common operation,
but it currently requires building it "by hand" from the `.basis()`.
This straightforward patch adds a method `O.basis_matrix()` which
computes `matrix(QQ, map(list, O.basis()))`.
Eventually, both orders and ideals should become children of a common
"quaternion lattice" class; this patch is a quick hack to reduce the
pain until that has happened.
URL: sagemath#35767
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing the basis matrix of a quaternion order is a common operation, but it currently requires building it "by hand" from the
.basis(). This straightforward patch adds a methodO.basis_matrix()which computesmatrix(QQ, map(list, O.basis())).Eventually, both orders and ideals should become children of a common "quaternion lattice" class; this patch is a quick hack to reduce the pain until that has happened.