Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test output for ipywidgets 8.0.5, part deux #35499

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix test output for ipywidgets 8.0.5, part deux #35499

merged 1 commit into from
Apr 23, 2023

Conversation

collares
Copy link
Contributor

📚 Description

Apply the change introduced in #35336 to the corresponding .rst file as well.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 954c0c0

@kiwifb
Copy link
Member

kiwifb commented Apr 13, 2023

Seems like a real oversight that should have been caught.

kiwifb
kiwifb approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trivial change matching the previous PR.

@antonio-rojas
Copy link
Contributor

Thanks. This file is not installed, so I did not test it.

@vbraun vbraun merged commit 41c256a into sagemath:develop Apr 23, 2023
@collares collares deleted the ipywidgets805 branch April 23, 2023 15:53
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwifb kiwifb kiwifb approved these changes

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

Assignees
No one assigned
Labels
c: packages: standard t: tests
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@collares @kiwifb @antonio-rojas @vbraun @mkoeppe