Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cython-linting inside categories/ #35408

Merged
merged 1 commit into from
Apr 13, 2023
Merged

some cython-linting inside categories/ #35408

merged 1 commit into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Using cython-lint to find issues in pyx files in he categories folder, then fix them manually.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

dcoudert
dcoudert approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this changes. You could have mentioned in the PR description that you remove deprecation warning introduced in trac ticket 26879 (4 years ago). So I'm doing it here.

@vbraun vbraun merged commit 31592df into sagemath:develop Apr 13, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe