Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version specifiers of python packages for conda #35350

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

For some python packages, conda installed an incompatible version which was then uninstalled and replaced by the correct version during the pip install src step. This PR adds the missing version specifiers in the conda dist files. It also adds a check in the conda ci workflow and runs the conda workflow automatically on package updates (using the label) to prevent such mismatches in the future.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez requested review from isuruf and mkoeppe March 26, 2023 06:58
@tobiasdiez tobiasdiez added s: needs review s: run conda ci Run the conda workflow on this PR. labels Mar 26, 2023
@tobiasdiez tobiasdiez added s: run conda ci Run the conda workflow on this PR. and removed s: run conda ci Run the conda workflow on this PR. labels Mar 26, 2023
@tobiasdiez
Copy link
Contributor Author

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 8dd6f2e

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (8dd6f2e) 88.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35350      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.01%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353464      -16     
- Misses       45375    45391      +16     

see 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tobiasdiez
Copy link
Contributor Author

Thanks for the review!

@vbraun vbraun merged commit d7eda9b into sagemath:develop Apr 6, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: run conda ci Run the conda workflow on this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants