fixing some E502 outside of schemes and combinat #35317

fchapoton · 2023-03-20T19:24:38Z

📚 Description

This fixes some pycodestyle warnings about

E502 the backslash is redundant between brackets

in py files outside the folders combinat/ and schemes/

📝 Checklist

I have made sure that the title is self-explanatory and the description concisely explains the PR.
I have linked an issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

codecov-commenter · 2023-03-20T23:35:39Z

Codecov Report

Patch coverage: 76.54% and project coverage change: -0.01 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (b12a307) 88.61%.

❗ Current head b12a307 differs from pull request most recent head 3dd56c5. Consider uploading reports for the commit 3dd56c5 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35317      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.01%     
===========================================
  Files         2148     2148              
  Lines       398855   398847       -8     
===========================================
- Hits        353480   353435      -45     
- Misses       45375    45412      +37

Impacted Files	Coverage Δ
src/sage/interfaces/maxima_abstract.py	`82.24% <0.00%> (ø)`
src/sage/libs/ntl/all.py	`100.00% <ø> (ø)`
...uadratic_forms/quadratic_form__reduction_theory.py	`72.51% <31.03%> (+0.68%)`	⬆️
src/sage/interfaces/singular.py	`88.83% <50.00%> (ø)`
...function_field/drinfeld_modules/drinfeld_module.py	`96.03% <50.00%> (ø)`
src/sage/symbolic/assumptions.py	`90.56% <50.00%> (ø)`
src/sage/databases/sql_db.py	`79.11% <73.33%> (ø)`
src/sage/crypto/mq/rijndael_gf.py	`80.09% <75.00%> (ø)`
...bras/lie_conformal_algebra_with_structure_coefs.py	`96.77% <81.81%> (ø)`
...e_conformal_algebras/weyl_lie_conformal_algebra.py	`91.89% <81.81%> (+2.14%)`	⬆️
... and 15 more

... and 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mkoeppe · 2023-03-21T05:05:27Z

src/sage/algebras/lie_conformal_algebras/bosonic_ghosts_lie_conformal_algebra.py

@@ -87,29 +87,31 @@ def __init__(self, R, ngens=2, names=None, index_set=None):
        """
        from sage.rings.integer_ring import ZZ
        try:
-            assert (ngens in ZZ and ngens > 0 and ngens % 2 == 0)
+            assert (ngens in ZZ and ngens > 0 and not ngens % 2)
        except AssertionError:


Not a fan of this replacement. Seems harder to read for me after the change

This is more pythonic and slightly faster.

src/sage/algebras/lie_conformal_algebras/lie_conformal_algebra_element.py

src/sage/crypto/mq/rijndael_gf.py

src/sage/databases/sql_db.py

src/sage/interfaces/rubik.py

src/sage/quadratic_forms/quadratic_form__reduction_theory.py

github-actions · 2023-03-21T14:56:56Z

Documentation preview for this PR is ready! 🎉
Built with commit: 3dd56c5

fixing some E502 outside of schemes and combinat

b12a307

fchapoton added s: needs review t: refactoring labels Mar 20, 2023