Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.topology: Move imports from sage.graphs, sage.homology into methods #35263

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 11, 2023

📚 Description

Part of:

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (8d79ca8) 88.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35263      +/-   ##
===========================================
- Coverage    88.62%   88.60%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353412      -68     
- Misses       45375    45443      +68     
Impacted Files Coverage Δ
src/sage/topology/cubical_complex.py 95.56% <100.00%> (ø)
src/sage/topology/delta_complex.py 94.51% <100.00%> (ø)
src/sage/topology/simplicial_complex_morphism.py 90.36% <100.00%> (ø)
src/sage/topology/simplicial_set.py 95.67% <100.00%> (ø)
src/sage/topology/simplicial_set_constructions.py 89.34% <100.00%> (ø)
src/sage/topology/simplicial_set_examples.py 95.07% <100.00%> (ø)
src/sage/topology/simplicial_set_morphism.py 91.59% <100.00%> (ø)

... and 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 11, 2023

Thank you!

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 8d79ca8

@vbraun vbraun merged commit 45e98cb into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants