Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the PR template #35141

Merged
merged 5 commits into from
Mar 26, 2023
Merged

Revise the PR template #35141

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f3416b
Edit the PR template
kwankyu Feb 15, 2023
e51619e
More edits in dependencies section
kwankyu Feb 15, 2023
c60f1de
Keep dependencies as a list
kwankyu Feb 15, 2023
726a53d
Merge branch 'develop' into fix/pr-template
kwankyu Feb 20, 2023
eea03f2
Merge branch 'develop' into fix/pr-template
kwankyu Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,28 @@
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1"
-->
### 📚 Description
<!-- Please provide a concise, informative and self-explanatory title. -->
<!-- Don't put issue numbers in the title. Put it in the Description below. -->
kwankyu marked this conversation as resolved.
Show resolved Hide resolved

### :books: Description

<!-- Describe your changes here in detail -->
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" -->
<!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it appropriately. -->

### 📝 Checklist
### :memo: Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. -->

- [ ] I have made sure that the title is self-explanatory and the description concisely explains the PR.
- [ ] I have linked an issue or discussion.
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
### :hourglass: Dependencies

<!-- List all open PRs that this PR logically depends on
Depends on #12345: short description why this is a dependency
kwankyu marked this conversation as resolved.
Show resolved Hide resolved
Depends on #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->