Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-linux: Remove unmaintained local-conda runs #35125

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 14, 2023

📚 Description

These are jobs that run directly on the GH Actions container instead of using Docker.
We remove them.

These jobs have been failing for a long time.
Newer tests for conda-forge have been added in ci-conda.yml, which makes these ones here obsolete.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez
Copy link
Contributor

Shouldn't be then the corresponding part of the tox ini file also be removed? Also, what is the difference between this tox-based conda run and the one in conda-ci?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2023

Shouldn't be then the corresponding part of the tox ini file also be removed?

No, the tox.ini can be used locally.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2023

what is the difference between this tox-based conda run and the one in conda-ci?

The one removed here builds sage-the-distribution on top of conda-forge. But this mode of installation is also tested using docker-conda-forge, which is more robust because we have more control over this environment than we do over the github actions container.

In contrast, in conda-ci, we use the "experimental" method of running sagelib directly on top of conda-forge.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Makes sense!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2023

Thank you!

@tobiasdiez tobiasdiez changed the title .github/workflows/ci-linux.yml: Remove unmaintained local-conda runs ci-linux: Remove unmaintained local-conda runs Feb 14, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: e25deb6

@dimpase
Copy link
Member

dimpase commented Feb 14, 2023

merging, as it improves CI by removing broken tests

@dimpase dimpase merged commit e310936 into sagemath:develop Feb 14, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants