Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade polymake to 4.9 #35085

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Upgrade polymake to 4.9 #35085

merged 4 commits into from
Mar 19, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 12, 2023

📚 Description

Fixes #34866

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

Codecov Report

Base: 88.60% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0489c98) compared to base (c000c95).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35085      +/-   ##
===========================================
- Coverage    88.60%   88.58%   -0.02%     
===========================================
  Files         2136     2136              
  Lines       396142   396142              
===========================================
- Hits        350990   350931      -59     
- Misses       45152    45211      +59
Impacted Files Coverage Δ
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 50.71% <0.00%> (-2.02%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-1.58%) ⬇️
...onformal_algebras/lie_conformal_algebra_element.py 95.52% <0.00%> (-1.50%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/combinat/posets/poset_examples.py 87.53% <0.00%> (-1.01%) ⬇️
src/sage/coding/channel.py 97.10% <0.00%> (-0.73%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe added this to the sage-9.9 milestone Feb 12, 2023
@mkoeppe mkoeppe requested review from kliem and dimpase February 12, 2023 13:38
kliem
kliem reviewed Feb 12, 2023
View reviewed changes
build/pkgs/polymake/spkg-install.in
@@ -21,6 +21,10 @@ if [ -x $SAGE_LOCAL/bin/lrs1 ]; then
more_configure_options="$more_configure_options --with-lrs=$SAGE_LOCAL"
fi

# Put these includes on the front, to avoid shadowing by installed headers
# from a previous version. (polymake 4.8 puts these includes to the end.)
export CXXFLAGS="-I$(pwd)/include/core-wrappers -I$(pwd)/include/core $CXXFLAGS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find out, that you need to do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error when I tried the 4.8 upgrade, and I stared long enough at the command lines...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there really is no reference to this solution.

@kliem
Copy link
Contributor

kliem commented Feb 12, 2023

It's wonderful how this works out of the box nowadays. Just typing sage -i polymake does the trick.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2023

Thank you!

@vbraun vbraun merged commit af6c040 into sagemath:develop Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kliem kliem kliem approved these changes

@dimpase dimpase Awaiting requested review from dimpase

Assignees
No one assigned
Labels
c: geometry c: packages: optional
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

Upgrade polymake to 4.9
4 participants
@mkoeppe @codecov-commenter @kliem @vbraun