Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NTL's MinPolyMod() for more rings #34966

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 6, 2023

Fixes #34958.

@fchapoton fchapoton self-requested a review February 6, 2023 13:33
@yyyyx4 yyyyx4 force-pushed the public/implement_minpoly_mod_for_more_polynomial_rings branch from aa2c628 to f1d6042 Compare February 8, 2023 02:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.58% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (61212ac) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34966   +/-   ##
========================================
  Coverage    88.58%   88.59%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351655   351669   +14     
+ Misses       45306    45292   -14     
Impacted Files Coverage Δ
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/quadratic_forms/binary_qf.py 92.03% <0.00%> (-0.75%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/graphs/generic_graph.py 89.04% <0.00%> (-0.48%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/combinat/tableau.py 95.86% <0.00%> (-0.35%) ⬇️
src/sage/graphs/generators/random.py 91.95% <0.00%> (-0.35%) ⬇️
...aphs/graph_decompositions/modular_decomposition.py 88.82% <0.00%> (-0.29%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/rings/function_field/ideal.py 89.47% <0.00%> (-0.17%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4 yyyyx4 force-pushed the public/implement_minpoly_mod_for_more_polynomial_rings branch from f1d6042 to 61212ac Compare February 14, 2023 00:20
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 61212ac

Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vbraun vbraun merged commit 830d3ed into sagemath:develop Feb 24, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 24, 2023
@yyyyx4 yyyyx4 deleted the public/implement_minpoly_mod_for_more_polynomial_rings branch February 24, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use NTL's MinPolyMod() for more rings
6 participants