Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve camera positioning for threejs #34960

Merged
merged 5 commits into from
Feb 19, 2023
Merged

Improve camera positioning for threejs #34960

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a80f14a
Improve camera positioning for threejs
kwankyu Feb 6, 2023
0a50547
Merge branch 'develop' into fix/34822/better-position-camera
kwankyu Feb 7, 2023
aa9937b
Merge branch 'develop' into fix/34822/better-position-camera
kwankyu Feb 8, 2023
23e35c0
Merge branch 'develop' into fix/34822/better-position-camera
kwankyu Feb 8, 2023
952a6c9
Merge branch 'develop' into fix/34822/better-position-camera
kwankyu Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/sage/ext_data/threejs/threejs_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,17 @@
camera.up.set( 0, 0, 1 );
camera.position.set( a[0]*xMid, a[1]*yMid, a[2]*zMid );

var offset = new THREE.Vector3( a[0]*xRange, a[1]*yRange, a[2]*zRange );
// camera is positioned so that the line from the camera to the center
// of the bounding sphere of the objects makes an angle of 60 degrees with x-axis
// and an angle of 30 degrees with z-axis and the field of view of the camera looking
// at the center has an angle of 45 degrees.
const sin8 = Math.sin(Math.PI / 8);
const sin5 = Math.sin(Math.PI / 5);
const cos5 = Math.cos(Math.PI / 5);
const sin3 = Math.sin(Math.PI / 3);
const cos3 = Math.cos(Math.PI / 3);
var r = midToCorner / sin8;
var offset = new THREE.Vector3( r * sin3 * cos5, r * sin3 * sin5, r * cos3 );

if ( options.viewpoint ) {

Expand Down Expand Up @@ -569,7 +579,7 @@
setTimeout( function() { m.style.display = 'none'; }, 2000 );

}

</script>

<div id="menu-container" onclick="toggleMenu()">&#x24d8;
Expand Down