Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing equality test in attrcall #5524

Closed
nthiery opened this issue Mar 15, 2009 · 10 comments
Closed

Fix missing equality test in attrcall #5524

nthiery opened this issue Mar 15, 2009 · 10 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Mar 15, 2009

The patch fixes the missing equality test methods in attrcall:

sage: attrcall("bla") == attrcall("bla")
False

which was, among others, breaking pickling tests.

CC: @sagetrac-sage-combinat @jbandlow

Component: misc

Keywords: attrcall

Author: Nicolas M. Thiéry

Reviewer: Jason Bandlow

Merged: sage-4.3.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/5524

@sagetrac-mabshoff

This comment has been minimized.

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.4.2 milestone Mar 15, 2009
@nthiery
Copy link
Contributor Author

nthiery commented Jan 26, 2010

Changed keywords from none to attrcall

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor Author

nthiery commented Jan 26, 2010

Reviewer: Jason Bandlow

@nthiery
Copy link
Contributor Author

nthiery commented Jan 26, 2010

Author: Nicolas M. Thiéry

@nthiery nthiery changed the title attrcall missing __cmp__ Fix missing equality test in attrcall Jan 26, 2010
@nthiery
Copy link
Contributor Author

nthiery commented Jan 26, 2010

Attachment: trac_5524_attrcall_eq.patch.gz

@nthiery nthiery assigned nthiery and unassigned sagetrac-cwitty Jan 26, 2010
@jbandlow
Copy link

comment:4

I'm getting a failing doctest:

sage -t  "devel/sage-trac/sage/misc/misc.py"                
**********************************************************************
File "/usr/local/src/sage/devel/sage-trac/sage/misc/misc.py", line 2103:
    sage: TestSuite(f).run()
Exception raised:
...
AttributeError: 'AttrCallObject' object has no attribute '_tester'

I'm applying on top of 4.3.1 plus #7976, #7921, #7938, #8028. Am I missing something?

@nthiery
Copy link
Contributor Author

nthiery commented Jan 26, 2010

comment:5

Replying to @jbandlow:

I'm getting a failing doctest:
I'm applying on top of 4.3.1 plus #7976, #7921, #7938, #8028. Am I missing something?

I should have mentioned it depends on #8001.

@jbandlow
Copy link

comment:6

Thanks. That fixes it. Passes tests and looks good to me.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 30, 2010

Merged: sage-4.3.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants