Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to element_wrapper #8028

Closed
nthiery opened this issue Jan 21, 2010 · 4 comments
Closed

Improvements to element_wrapper #8028

nthiery opened this issue Jan 21, 2010 · 4 comments
Assignees
@sagetrac-sage-combinat
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-4.3.2

Comments

@nthiery
Copy link
Contributor

nthiery commented Jan 21, 2010

Improvements to element_wrapper:

  • Do not define __cmp__ by default to not force a total order on subclasses
  • Define __lt__ to have elements incomparable by default
  • Provide alternative implementations as _cmp_by_value, _lt_by_value
  • Update accordingly:
    • FiniteSemigroups().example(), FiniteCoxeterGroups().example()
  • Misc polishing (copyright header, whitespace, ...)

This will be used by upcoming patches for crystals, ...

Component: combinatorics

Keywords: ElementWrapper, partial order

Author: Nicolas M. Thiéry

Reviewer: Florent Hivert

Merged: sage-4.3.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8028
@nthiery nthiery added this to the sage-4.3.2 milestone Jan 21, 2010
@nthiery
Copy link
Contributor Author

nthiery commented Jan 21, 2010

Attachment: trac_8028_element_wrapper-improvement-nt.patch.gz

@nthiery

This comment has been minimized.

Sign in to view
@hivert
Copy link

hivert commented Jan 23, 2010

comment:2

Everything ok !

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

Merged: sage-4.3.2.alpha0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jan 23, 2010
@dwbump dwbump mannequin mentioned this issue Feb 2, 2010
Closed
@sagetrac-abmasse sagetrac-abmasse mannequin mentioned this issue Mar 8, 2010
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.3.2
Development

No branches or pull requests
2 participants
@nthiery @hivert