Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# 32-bit / # 64-bit tag breaks block-scoped doctest tags #36099

Closed
mkoeppe opened this issue Aug 17, 2023 · 0 comments · Fixed by #38029
Closed

# 32-bit / # 64-bit tag breaks block-scoped doctest tags #36099

mkoeppe opened this issue Aug 17, 2023 · 0 comments · Fixed by #38029
Labels
c: doctest framework t: bug
Milestone
sage-10.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 17, 2023

via DocTestSource._create_doctests:

                        # We insert blank lines to make up for the removed lines
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 11, 2024
sagemathgh-37279: Fix some doctest warnings
f71381c 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
These are some of the last remaining doctest warnings as of 10.3.beta7,
as seen e.g. in https://github.com/sagemath/sage/pull/37250/files
"Unchanged files with check annotations".

The ones not fixed here will need a solution for:
- sagemath#36099

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37279
Reported by: Matthias Köppe
Reviewer(s): David Coudert
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 3, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue May 29, 2024
sagemathgh-38029: Fix interaction of # 32-bit / # 64-bit tag with blo…
6ccce61 
…ck-scoped doctest tags

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#36099

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38029
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 31, 2024
sagemathgh-38029: Fix interaction of # 32-bit / # 64-bit tag with blo…
986989a 
…ck-scoped doctest tags

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#36099

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38029
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework t: bug
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging a pull request may close this issue.

Fix interaction of # 32-bit / # 64-bit tag with block-scoped doctest tags mkoeppe/sage
1 participant
@mkoeppe