Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random testing has revealed a problem in test_karatsuba_multiplication #35715

Open
2 tasks done
vbraun opened this issue Jun 3, 2023 · 8 comments
Open
2 tasks done

Random testing has revealed a problem in test_karatsuba_multiplication #35715

vbraun opened this issue Jun 3, 2023 · 8 comments
Labels
t: bug

Comments

@vbraun
Copy link
Member

vbraun commented Jun 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

  • I have read the documentation and troubleshoot guide

Environment

- **OS**: Ubuntu 18.04 32 bit
- **Sage Version**: 10.1.beta1

Steps To Reproduce

Random fail when running the tests, just saw it for the first time on a build bot:

**********************************************************************
File "src/sage/rings/tests.py", line 449, in sage.rings.tests.?
Failed example:
    test_karatsuba_multiplication(QQbar, 3, 3, numtests=2)    # long time     # optional - sage.rings.number_field
Expected nothing
Got:
    Random testing has revealed a problem in test_karatsuba_multiplication
    Please report this bug!  You may be the first
    person in the world to have seen this problem.
    Please include this random seed in your bug report:
    Random seed: 164480309984640964737929113640888706047
    ValueError('Multiplication failed')
**********************************************************************
1 item had failures:
   1 of  13 in sage.rings.tests.?
    [62 tests, 1 failure, 25.59 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/rings/tests.py  # 1 doctest failed
----------------------------------------------------------------------

Expected Behavior

Doctest should not fail

Actual Behavior

Doctest fails (randomly, seed is provided above)

Additional Information

probably due to #35443
@vbraun vbraun added the t: bug label Jun 3, 2023
@vbraun
Copy link
Member Author

vbraun commented Jun 3, 2023

@tornaria FYI

@tobiasdiez tobiasdiez mentioned this issue Dec 25, 2023
Closed
@tobiasdiez
Copy link
Contributor

More info on how to reproduce this (or a very closely related error:: #36961

@tobiasdiez tobiasdiez mentioned this issue Dec 25, 2023
Closed
5 tasks
@DaveWitteMorris DaveWitteMorris mentioned this issue Feb 4, 2024
Closed
@GiacomoPope
Copy link
Contributor

GiacomoPope commented Mar 6, 2024 •
edited
Loading

This has also cropped up here: #37455

Each time I saw the error in the CI I could not reproduce it locally.

@mantepse mantepse mentioned this issue Mar 7, 2024
Merged
5 tasks
@fchapoton fchapoton mentioned this issue Mar 7, 2024
Merged
2 tasks
@mezzarobba
Copy link
Member

Also here: #37193 (comment)

vbraun pushed a commit to vbraun/sage that referenced this issue Mar 30, 2024
sagemathgh-37561: enrich the test_karatsuba failure message with expl…
644ba54 
…icit elements

    
To help debug the random failure in `test_karatsuba_multiplication`, let
us have a more precise error message in case of failure there.

cf sagemath#35715

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37561
Reported by: Frédéric Chapoton
Reviewer(s): Martin Rubey
@GiacomoPope
Copy link
Contributor

Another example of this:

#37441 (comment)

sage: from sage.rings.tests import test_karatsuba_multiplication ## line 429 ##
sage: test_karatsuba_multiplication(ZZ, 6, 5, verbose=True, seed=42) ## line 430 ##
test_karatsuba_multiplication: ring=Univariate Polynomial Ring in x over Integer Ring, threshold=2
  (x^6 + 4*x^5 + 4*x^4 - 3*x^3 - x^2 - x)*(2*x^4 + 3*x^3 - 20*x^2 - 2*x + 1)
  (4*x^5 + 16*x^2 + x - 41)*(x^2 + x - 1)
  (8*x^2 + 2*x + 1)*(3)
  (-4*x - 1)*(-8*x^2 - x)
  (-x^6 - x^3 - x^2 + x + 1)*(2*x^3 - x + 3)
  (-x^2 + x + 1)*(x^4 + x^3 - x^2 - x + 76)
  (4*x^3 + x^2 + 6)*(-x^2 - 5*x)
  (x + 4)*(-x + 5)
  (-2*x)*(3*x^2 - x)
  (x^6 + 21*x^5 + x^4 + 4*x^3 - x^2)*(14*x^4 + x^3 + 2*x^2 - 12*x)
sage: rings = [QQ] ## line 445 ##
sage: rings += [ZZ[I], ZZ[I, sqrt(2)]]                                          # needs sage.rings.number_field sage.symbolic ## line 446 ##
sage: rings += [GF(49, 'a')]                                                    # needs sage.rings.finite_rings ## line 447 ##
sage: rings += [MatrixSpace(GF(17), 3)]                                         # needs sage.modules ## line 448 ##
sage: for C in rings:                                                           # needs sage.modules
    test_karatsuba_multiplication(C, 10, 10) ## line 449 ##
sage: test_karatsuba_multiplication(QQbar, 3, 3, numtests=2)    # long time, needs sage.rings.number_field ## line 454 ##

The output following #37561 makes this error more verbose.

@mezzarobba
Copy link
Member

Another example of this:

#37441 (comment)

This one isn't a “multiplication failed” but a plain crash—with no new info from #37561, presumably due to output buffering.

@fchapoton
Copy link
Contributor

Here is more data

Multiplication failed for elements defined by
R1.<y> = QQ[]
R2.<x> = QQbar[]
8*QQbar.polynomial_root(AA.common_polynomial(y^2 + 1), CIF(RIF(RR(0)), RIF(-RR(1))))*x^3 + 1/5*QQbar.polynomial_root(AA.common_polynomial(y^2 - y + 5), CIF(RIF(RR(0.49999999999999994), RR(0.50000000000000011)), RIF(RR(2.1794494717703365), RR(2.179449471770337))))*x^2 + QQbar(1/2*AA.polynomial_root(AA.common_polynomial(y^2 - 2), RIF(RR(1.4142135623730949), RR(1.4142135623730951))))*x + QQbar(1/4*AA.polynomial_root(AA.common_polynomial(y^2 - y - 4), RIF(RR(2.5615528128088298), RR(2.5615528128088303))))
and
R1.<x> = QQbar[]
R2.<y> = QQ[]
2/3*x^3 + QQbar(AA.polynomial_root(AA.common_polynomial(y^2 - y - 8988), RIF(-RR(94.30638164174394), -RR(94.306381641743926))))*x^2 + (QQbar.polynomial_root(AA.common_polynomial(y^2 + 1), CIF(RIF(RR(0)), RIF(RR(1)))) - 1)*x + QQbar(1/15*AA.polynomial_root(AA.common_polynomial(y^2 - 106), RIF(-RR(10.295630140987001), -RR(10.295630140986999))) + 11/15)

@user202729
Copy link
Contributor

A (slightly different?) error

2025-02-01T12:28:25.8118182Z sage -t --long --warn-long 30.0 --random-seed=286735480429121101562228604801325644303 src/sage/rings/tests.py
2025-02-01T12:28:25.8119196Z **********************************************************************
2025-02-01T12:28:25.8131737Z ##[error]Failed example:: Got: Random testing has revealed a problem in test_karatsuba_multiplication
Please report this bug!  You may be the first
person in the world to have seen this problem.
Please include this random seed in your bug report:
Random seed: 108989663366345573243852144936891050366
NTLError('FFT prime index too large')
                                                                                                                                                               
2025-02-01T12:28:25.8135159Z     test_karatsuba_multiplication(QQbar, 3, 3, numtests=2)    # long time, needs sage.rings.number_field
2025-02-01T12:28:25.8135895Z Expected nothing
2025-02-01T12:28:25.8136213Z Got:
2025-02-01T12:28:25.8136638Z     Random testing has revealed a problem in test_karatsuba_multiplication
2025-02-01T12:28:25.8137291Z     Please report this bug!  You may be the first
2025-02-01T12:28:25.8137783Z     person in the world to have seen this problem.
2025-02-01T12:28:25.8138288Z     Please include this random seed in your bug report:
2025-02-01T12:28:25.8142063Z     Random seed: 108989663366345573243852144936891050366
2025-02-01T12:28:25.8142576Z     NTLError('FFT prime index too large')
2025-02-01T12:28:44.7428637Z **********************************************************************
2025-02-01T12:28:44.7429725Z 1 item had failures:
2025-02-01T12:28:44.7430350Z    1 of  13 in sage.rings.tests.?
2025-02-01T12:28:44.7521085Z     [62 tests, 1 failure, 823.68s wall]

https://github.com/sagemath/sage/actions/runs/13088275053/job/36522122850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vbraun @mezzarobba @tobiasdiez @fchapoton @user202729 @GiacomoPope