Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for fricas #33575

Closed
mkoeppe opened this issue Mar 27, 2022 · 5 comments · Fixed by #35838
Closed

Feature for fricas #33575

mkoeppe opened this issue Mar 27, 2022 · 5 comments · Fixed by #35838
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-10.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 27, 2022

CC: @orlitzky @tornaria @seblabbe

Component: interfaces

Keywords: FriCAS

Branch/Commit: u/mkoeppe/feature_for_axiom @ 73ad696

Issue created by migration from https://trac.sagemath.org/ticket/33575
@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 27, 2022
@mkoeppe mkoeppe changed the title Feature for axiom Feature for fricas Mar 27, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 27, 2022

Branch: u/mkoeppe/feature_for_axiom

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 27, 2022

Commit: 73ad696

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 27, 2022

comment:3

An issue is that currently Sage creates an instance of the FriCAS interface as part of loading sage.interfaces.all. This now fails:

  File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/interfaces/fricas.py", line 291, in __init__
    fricas_exe = FriCASExecutable().absolute_filename()
  File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/features/__init__.py", line 615, in absolute_filename
    raise FeatureNotPresentError(self,
sage.features.FeatureNotPresentError: fricas_exe is not available.
Executable 'fricas' not found on PATH.
No equivalent system packages for homebrew are known to Sage.
To install fricas_exe using the Sage package manager, you can try to run:
  !sage -i fricas
No equivalent system packages for pip are known to Sage.

New commits:

73ad696src/sage/features/interfaces.py: Add FriCASExecutable, FriCAS

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@mantepse
Copy link
Contributor

Changed keywords from none to FriCAS

@seblabbe
Copy link
Contributor

comment:6

needs review?

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
dimpase pushed a commit to dimpase/sage that referenced this issue Jun 30, 2023
@dimpase
implement sage's feature for FriCAS
38d728e 
This is taken from sagemath#33575
vbraun pushed a commit to vbraun/sage that referenced this issue Dec 4, 2023
sagemathgh-35838: FriCAS spkg-configure and Feature
b84c6b1 
    
As FriCAS is only used as an executable, this is straightforward; quite
a number of systems has Fricas 1.3.8, so this is useful, too.

The FriCAS pexpect interface now uses the new `Executable` feature to
determine the absolute pathname of the fricas executable (unless
executed remotely).
This is made possible by a simple refactor of the
`sage.interfaces.expect.Expect` class: Computing the effective command
line is no longer done in `set_server_and_command` (called by
`__init__`); it is delayed until an interface is started and needs the
command line.

- Fixes sagemath#35837
- Fixes sagemath#33575

Dependencies: The changes in `sage.interfaces` outside of `.expect` and
`.fricas` are all from the following PR and do not need review.

- Depends on sagemath#36656 (merged here)
    
URL: sagemath#35838
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, François Bissey, Matthias Köppe
@vbraun vbraun closed this as completed in 9c4fc77 Dec 6, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

FriCAS spkg-configure and Feature dimpase/sage
3 participants
@seblabbe @mkoeppe @mantepse