Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expired deprecations that use lazy_import(MODULE, "*") #33308

Closed
mkoeppe opened this issue Feb 7, 2022 · 8 comments
Closed

Remove expired deprecations that use lazy_import(MODULE, "*") #33308

mkoeppe opened this issue Feb 7, 2022 · 8 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 7, 2022

After building Sage, in the first run, Sage spends some time building the "lazy import cache".

This whole mechanism (from #8456, modified in #11924, #12670) is currently only used for a total of 3 re-imports with deprecation. They could be easily be rewritten by just listing all symbols instead of using "*"; but it turns out that the deprecations have all expired already (#19150, #26370, #27337), so we can remove them.

$ git grep '^lazy_import.*[*]'
src/sage/combinat/lyndon_word.py:lazy_import('sage.combinat.words.lyndon_word', '*', deprecation=19150)
src/sage/rings/invariant_theory.py:lazy_import('sage.rings.invariants.invariant_theory', '*', deprecation=26370)
src/sage/tests/all.py:lazy_import('sage.tests.arxiv_0812_2725', '*', deprecation=27337)

CC: @tscrim @jhpalmieri

Component: misc

Author: Matthias Koeppe

Branch/Commit: be8a401

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33308

@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 7, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 7, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 7, 2022

New commits:

b55251bsrc/sage/combinat/lyndon_word.py: Remove
ebd5a99src/sage/rings/invariant_theory.py: Remove
be8a401src/sage/tests/all.py: Remove deprecated imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 7, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 7, 2022

Commit: be8a401

@orlitzky
Copy link
Contributor

orlitzky commented Feb 7, 2022

comment:3

Sure.

@orlitzky
Copy link
Contributor

orlitzky commented Feb 7, 2022

Reviewer: Michael Orlitzky

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 7, 2022

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants