-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate imports in sage.tests.all: no need to important into global namespace #27337
Comments
Branch: u/jhpalmieri/tests.all |
Commit: |
New commits:
|
Reviewer: Travis Scrimshaw |
comment:3
I am very tempted to outright remove them, but there is that part of me that says we should deprecate no matter what (when it is not a bug). I leave the final decision on that up to you, but I think it is fine to not deprecate as this does not seem to have a meaningful use being imported (perhaps I am wrong). |
comment:4
I can't quite imagine a serious use, but I guess our policy is that they should be deprecated. How do you deprecate an import? Convert to |
comment:5
Yes, and there is a deprecation parameter you can pass. For example in
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:8
Thank you. |
Changed branch from u/jhpalmieri/tests.all to |
The file
sage/tests/all.py
is imported into the global namespace, and it containsThere is no need for these imports, so deprecate them now so we can remove them later.
Component: misc
Author: John Palmieri
Branch/Commit:
965fe8f
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/27337
The text was updated successfully, but these errors were encountered: