Obtain flexible maximal chains of a combinatorial polyhedron

[kliem]

We allow obtaining more flexible maximal chains specifying an index for a vertex and/or facet.

Depends on #31822

CC: @jplab @mkoeppe @yuan-zhou @tscrim

Component: geometry

Keywords: combinatorial polyhedron, maximal chain

Author: Jonathan Kliem

Branch/Commit: 98efbbf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31823

[kliem]

comment:2

Needs rebase.

[mkoeppe]

comment:3

What's the status here?

[kliem]

Changed branch from u/gh-kliem/flexible_maximal_chains to u/gh-kliem/flexible_maximal_chains-reb

[kliem]

Last 10 new commits:

4c0a4ae	initialize do_f_vector
542baee	merge in #31245
3e0229f	Merge tag '9.4.beta3' into t/31834/public/31834-reb2
8190917	Merge #31834
7f7e630	Merge #29683
ac5c327	Merge #31819
2e5908e	simplify a maximal chain
10f6519	specify Vindex and/or Hindex for maximal chain
1ba63c4	fix search for Hindex in dual case
11e024a	add test method for a maximal chain

[kliem]

Changed commit from 29a7871 to 11e024a

[kliem]

Changed dependencies from #31821, #31822 to #31822

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:6

It would be good to indicate in the the _test method what is randomized in the test. Other than that, LGTM.

[sagetrac-git]

Changed commit from 11e024a to 98efbbf

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

98efbbf

document what is random in _test_a_maximal_chain

[mkoeppe]

comment:8

Is anything missing here for positive review?

[tscrim]

comment:9

Nope, LGTM. I didn't get an email for the pushed commit and I forgot to check back to this ticket.

[vbraun]

Changed branch from u/gh-kliem/flexible_maximal_chains-reb to 98efbbf