Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on combinatorial polyhedron #31821

Closed
kliem opened this issue May 12, 2021 · 5 comments
Closed

Run tests on combinatorial polyhedron #31821

kliem opened this issue May 12, 2021 · 5 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@kliem
Copy link
Contributor

kliem commented May 12, 2021

We add a method _test_combinatorial_polyhedron to Polyhedron_base that runs the test suite on the combinatorial polyhedron.

We fix pickling of the combinatorial polyhedron in case there are equations by pickling from the matrix instead of a list of facets. This way the incidences will be exactly the same including the incidences corresponding to equations.

Depends on #31820

CC: @jplab @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: b285d95

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31821
@kliem kliem added this to the sage-9.4 milestone May 12, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented May 12, 2021

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe changed the title Run tests on combinatorial polyehdron Run tests on combinatorial polyhedron May 12, 2021
@kliem
Copy link
Contributor Author

kliem commented May 12, 2021

comment:4

Thank you.

@slel
Copy link
Member

slel commented May 13, 2021

comment:5

Oops, wrong ticket. Deleted my previous comment which was meant for #31822.

@slel
Copy link
Member

slel commented May 13, 2021

comment:6

Back to positive review, sorry for the noise.

@vbraun
Copy link
Member

vbraun commented Jun 19, 2021

Changed branch from u/gh-kliem/test_combinatorial_polyhedron to b285d95

@vbraun vbraun closed this as completed in f13536a Jun 19, 2021
This was referenced Jan 29, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
4 participants
@vbraun @slel @mkoeppe @kliem