Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sage.misc.dist.install_scripts #30207

Closed
mkoeppe opened this issue Jul 23, 2020 · 16 comments
Closed

Deprecate sage.misc.dist.install_scripts #30207

mkoeppe opened this issue Jul 23, 2020 · 16 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 23, 2020

This function does not belong into sagelib. If it is still needed at all, it should become a script in sage-the-distribution.

install_scripts is also mentioned in one place in the sage installation guide, src/doc/en/installation/source.rst. We update it.

https://groups.google.com/d/msg/sage-devel/M6S1bL_qU3Y/twdtVp0rBgAJ

CC: @EmmanuelCharpentier @jhpalmieri @saraedum

Component: build

Keywords: sd111

Author: John Palmieri

Branch/Commit: c77ecb0

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30207
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 23, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:2

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:3

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@jhpalmieri
Copy link
Member

Branch: u/jhpalmieri/deprecate-install-scripts

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

Commit: c77ecb0

@jhpalmieri
Copy link
Member

comment:8

Here's a branch. I removed hg, kash, and M2 from the scripts to be installed, since those are not connected to Sage packages anymore. Questions:

  • should we remove from .dist import install_scripts from sage.misc.all?
  • install_scripts is used in docker/Dockerfile. Is this necessary?

New commits:

c77ecb0trac 30207: deprecate install_scripts (from sage.misc.dist)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 27, 2022

comment:9

Cc'ing the maintainer of docker/Dockerfile

@jhpalmieri
Copy link
Member

comment:10

I did not do any updating of https://doc.sagemath.org/html/en/installation/source.html#installation-in-a-multiuser-environment, by the way.

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 2, 2022

comment:12

Replying to @jhpalmieri:

I did not do any updating of https://doc.sagemath.org/html/en/installation/source.html#installation-in-a-multiuser-environment, by the way.

I've moved this task to #33787

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 2, 2022

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member

comment:14

Thanks! Someone can take care of docker/Dockerfile in a later ticket, if it's an issue.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 2, 2022

comment:15

Replying to @jhpalmieri:

  • should we remove from .dist import install_scripts from sage.misc.all?

No, only after removing the function, I'd say.

@vbraun
Copy link
Member

vbraun commented May 17, 2022

Changed branch from u/jhpalmieri/deprecate-install-scripts to c77ecb0

@vbraun vbraun closed this as completed in cc7f3b5 May 17, 2022
@videlec videlec mentioned this issue Jan 7, 2023
Open
@seblabbe seblabbe mentioned this issue Jan 29, 2023
Open
mkoeppe added a commit to mkoeppe/sage that referenced this issue Apr 23, 2024
@mkoeppe
src/sage/misc/dist.py: Remove; deprecated in sagemath#30207 (2022)
5a8b125
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 28, 2024
sagemathgh-37856: sage.misc.dist: Remove; deprecated in sagemath#30207
0b2a719 
 (2022)

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Deprecated in:
- sagemath#30207 (2022)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37856
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 2, 2024
sagemathgh-37856: sage.misc.dist: Remove; deprecated in sagemath#30207
b14d3ec 
 (2022)

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Deprecated in:
- sagemath#30207 (2022)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37856
Reported by: Matthias Köppe
Reviewer(s):
@mantepse mantepse mentioned this issue May 10, 2024
Closed
@williamstein
Copy link
Contributor

Since I wrote this and found it to be very valuable, and others might, I've put it here

https://github.com/sagemathinc/cocalc-compute-docker/blob/main/src/sagemath/scripts/install_scripts.py

and this can be run using the script here

https://github.com/sagemathinc/cocalc-compute-docker/blob/main/src/sagemath/scripts/links-to-sage.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @williamstein @jhpalmieri @mkoeppe