Make libs doctests ready for random seeds

[kliem]

This ticket makes

sage -t --long --random-seed=n src/sage/libs/

pass for different values n than just 0.

CC: @DaveWitteMorris

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 2995c47

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/29964

[kliem]

comment:2

At least the following will need to be fixed:

sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/flint/nmod_poly_linkage.pxi  # 28 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_GF2E.pyx  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_mat_GF2.pyx  # 29 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_mat_GF2E.pyx  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_mat_ZZ.pyx  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_ZZ_p.pyx  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/ntl/ntl_ZZ.pyx  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/libs/singular/function.pyx  # 1 doctest failed

[kliem]

Dependencies: #29962

[kliem]

comment:5

The NTL function randomBits is documented incorrectly. Of course it returns a random number with n random bits which corresponds to a random number in [0, 2^n) and not 2^(n-1) as claimed.

[kliem]

Commit: 080538b

[kliem]

New commits:

080538b

make sage/libs ready for implicit fuzzing of doctests

[kliem]

Author: Jonathan Kliem

[kliem]

Branch: public/29964

[kliem]

comment:7

list(mult for factor, mult in decomp) <= list(range(2, 2 + len(decomp)))

This does not test for a sublist. I will implement such a quick test in #29969.

[kliem]

Changed dependencies from #29962 to #29969

[sagetrac-git]

Changed commit from 080538b to 6e02a46

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6e02a46

properly check if the list is strictly increasing

[kliem]

Changed dependencies from #29969 to none

[mezzarobba]

Reviewer: Marc Mezzarobba

[mezzarobba]

comment:10

I think I would have kept the examples in gauss() (and flagged it as random), and maybe removed the test that the matrix is not reduced (no real point IMO). But that's not big deal: please feel free to set the ticket to positive_review on my behalf either after changing that or if you disagree.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2995c47

keep a random doctest for illustration

[sagetrac-git]

Changed commit from 6e02a46 to 2995c47

[kliem]

comment:12

Ok, I added again one of the examples of gauss for illustration.

The test that the matrix is not reduced really tests that the remaining rows are all zero, which tests that the functions has worked correctly, I guess.

[kliem]

comment:13

Thank you.

[vbraun]

Changed branch from public/29964 to 2995c47