Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make misc doctests ready for random seeds #29969

Closed
kliem opened this issue Jun 24, 2020 · 10 comments
Closed

Make misc doctests ready for random seeds #29969

kliem opened this issue Jun 24, 2020 · 10 comments
Labels
c: doctest framework p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/misc/

pass for different values n than just 0.

CC: @DaveWitteMorris

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: bcd0654

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/29969
@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

comment:1

At least the following need fixes

sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/misc/misc.py  # 4 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/misc/prandom.py  # 35 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/misc/randstate.pyx  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/misc/sage_unittest.py  # 2 doctests failed

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2021

Commit: bcd0654

@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2021

Branch: public/29969

@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2021

Changed dependencies from #29962 to none

@kliem
Copy link
Contributor Author

kliem commented Jan 25, 2021

New commits:

bcd0654make sage/misc ready for implicit fuzzuing of doctests

@mezzarobba
Copy link
Member

comment:4

Looks good (and very thorough) to me, thank you!

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@kliem
Copy link
Contributor Author

kliem commented Jan 26, 2021

comment:5

Thank you for reviewing.

@vbraun
Copy link
Member

vbraun commented Feb 20, 2021

Changed branch from public/29969 to bcd0654

@vbraun vbraun closed this as completed in 46f654e Feb 20, 2021
@dimpase dimpase mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @mezzarobba @mkoeppe @kliem