Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend_polymake: Clean up imports #22740

Closed
mkoeppe opened this issue Apr 2, 2017 · 10 comments
Closed

backend_polymake: Clean up imports #22740

mkoeppe opened this issue Apr 2, 2017 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2017

Following up on #22683 comment 13,
we remove redundant import statements from backend_polymake.

CC: @kiwifb @tscrim

Component: geometry

Author: Matthias Koeppe

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22740

@mkoeppe mkoeppe added this to the sage-8.0 milestone Apr 2, 2017
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2017

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2017

Last 10 new commits:

ef23af4Polyhedron_base._polymake_init_: Add test for RDF polyhedra
205879fMatrix, MatrixSpace: Add coercion to polymake interface
e49765ePolymake: Fix tests whose error messages changed because we do not use files
51af468PolymakeElement.__iter__: New
2f0e059PolymakeElement._sage_: Implement for *Vector, *Matrix, QuadraticExtension
218dacaAdd Polyhedron_polymake
5ab94a2Merge tag '7.6' into t/22683/backend_polymake_for_polyhedron
8fd81c7Polyhedron_polymake._polymake_: Add doctest
952b860PolymakeElement.__iter__: Doc fixes
5eee110backend_polymake: Clean up imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2017

Commit: 5eee110

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2017

Author: Matthias Koeppe

@tscrim
Copy link
Collaborator

tscrim commented Apr 2, 2017

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2017

comment:4

I've made this change part of #22740 now. Marking this as duplicate.

@mkoeppe mkoeppe removed this from the sage-8.0 milestone Apr 2, 2017
@tscrim
Copy link
Collaborator

tscrim commented Apr 2, 2017

Changed commit from 5eee110 to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 2, 2017

Changed dependencies from #22683 to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 2, 2017

Changed branch from u/mkoeppe/backend_polymake__clean_up_imports to none

@embray
Copy link
Contributor

embray commented Jul 13, 2017

comment:6

Closing tickets in the sage-duplicate/invalid/wontfix module with positive_review (i.e. someone has confirmed they should be closed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants