Python 3 preparation: Handle the renaming of "urllib" and "urllib2"

[wluebbe]

The tool 2to3 changes the respective import statements to the new Py3 names.

But the code has to depend on the Python version!

There are 16 effected modules.

This ticket is tracked as a dependency of meta-ticket ticket:16052.

Component: distribution

Author: Frédéric Chapoton

Branch/Commit: 3098f5f

Reviewer: Volker Braun, R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/16080

[fchapoton]

Branch: public/16080

[fchapoton]

Commit: c9f3a98

[fchapoton]

New commits:

c9f3a98

trac #16080 changing imports of urllib,urrlib2,urlparse for py3 compatibility

[fchapoton]

Author: Frédéric Chapoton

[sagetrac-git]

Changed commit from c9f3a98 to ab05e06

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ab05e06

trac #16080 correct one doctest

[sagetrac-git]

Changed commit from ab05e06 to 3ac77d3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3ac77d3

trac #16080 move back 3 imports inside functions

[ohanar]

comment:6

Could you use six.moves.urllib instead? We already include six as a standard package, so it is fine to use it.

[vbraun]

comment:7

+1 to six.moves.urlib. Rest is great!

[fchapoton]

comment:8

I was using this page

http://python3porting.com/stdlib.html

as a reference, and it says that six could not handle urllib. Maybe this is outdated ?

Do we really gain something by using six instead of the "try except" ? In other words, do you really want me to spend more time on that ? I may have other things to do.

[sagetrac-git]

Changed commit from 3ac77d3 to 99699f6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

99699f6

trac #16080 now redone using six.moves

[vbraun]

Reviewer: Volker Braun, R. Andrew Ohana

[vbraun]

comment:11

merge conflict, probably with #19296

[fchapoton]

comment:12

This does not work. Some imports have to be modified. Work in progress.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f848c3b

trac #16080 correcting some imports

[sagetrac-git]

Changed commit from 99699f6 to f848c3b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3098f5f

Merge branch 'public/16080' into 6.10.b5

[sagetrac-git]

Changed commit from f848c3b to 3098f5f

[fchapoton]

comment:15

Better wait for the bot's green light before setting back to positive review.

[fchapoton]

comment:16

ok, seems to be good to go. Volker, do you approve ?

[vbraun]

Changed branch from public/16080 to 3098f5f