Generating function in FindStat interface #19296

stumpc5 · 2015-09-26T12:37:07Z

This ticket implements the generating function pull from a FindStat statistic and its search in the OEIS.

It also fixes some issues recently discovered, in particular #19543

CC: @mantepse

Component: packages: optional

Keywords: FindStat, OEIS

Work Issues: document

Author: Christian Stump, Martin Rubey

Branch/Commit: 15ec356

Reviewer: Martin Rubey, Christian Stump

Issue created by migration from https://trac.sagemath.org/ticket/19296

The text was updated successfully, but these errors were encountered:

stumpc5 · 2015-09-26T17:49:40Z

Branch: u/stumpc5/generating_function_in_findstat_interface

stumpc5 · 2015-09-26T17:51:39Z

Changed keywords from none to FindStat, OEIS

stumpc5 · 2015-09-26T17:51:39Z

Commit: eefeaae

stumpc5 · 2015-09-26T17:51:39Z

New commits:

`eefeaae`	`first version for generating function and automated oeis search, still to be improved`

stumpc5 · 2015-09-26T17:51:39Z

Author: Christian Stump

stumpc5 · 2015-09-26T17:51:39Z

Work Issues: document

sagetrac-git · 2015-09-26T17:54:32Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0a69285`	`cosmetic`

sagetrac-git · 2015-09-26T17:54:32Z

Changed commit from eefeaae to 0a69285

stumpc5 · 2015-09-26T17:56:22Z

comment:4

@mantepse, do I need to add the utf8 encoding in

self._generating_function = self._raw[FINDSTAT_STATISTIC_GENERATING_FUNCTION]

as in some of the other similar lines before?

sagetrac-git · 2015-09-27T08:26:48Z

Changed commit from 0a69285 to b0eda28

sagetrac-git · 2015-09-27T08:26:48Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b0eda28`	`remved a leftover print command`

sagetrac-git · 2015-09-27T09:32:05Z

Branch pushed to git repo; I updated commit sha1. New commits:

`6640df6`	`added name_plural method`

sagetrac-git · 2015-09-27T09:32:05Z

Changed commit from b0eda28 to 6640df6

sagetrac-git · 2015-09-27T15:04:12Z

Changed commit from 6640df6 to e1b0c89

sagetrac-git · 2015-09-27T15:04:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e1b0c89`	`added verbose and improved the oeis search`

sagetrac-git · 2015-09-27T15:48:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9926f7f`	`added max length to oeis search`

sagetrac-git · 2015-09-27T15:48:38Z

Changed commit from e1b0c89 to 9926f7f

sagetrac-git · 2015-09-27T18:56:43Z

Branch pushed to git repo; I updated commit sha1. New commits:

`83d5332`	`improved max length to oeis search`

sagetrac-git · 2015-09-27T18:56:43Z

Changed commit from 9926f7f to 83d5332

sagetrac-git · 2015-09-28T13:28:15Z

Changed commit from 83d5332 to f544c28

sagetrac-git · 2015-09-28T13:28:15Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ea11793`	`added list of coefficient option to generating functions`
`595e289`	`added some documentation`
`f544c28`	`added name to json and pull it from there`

mantepse · 2015-09-28T15:26:18Z

comment:11

I think it would be better to have the commits added name to json and pull it from there and added name_plural method in a separate ticket. Actually, I even have a bug to fix...

stumpc5 · 2015-09-29T06:26:02Z

comment:12

@mantepse If I now push the new collections.json without the CollectionLevelsPrecomputed field. Is then the current version of the interface braking? I guess so, right?

stumpc5 · 2015-09-29T06:28:03Z

comment:13

Replying to @mantepse:

I think it would be better to have the commits added name to json and pull it from there and added name_plural method in a separate ticket. Actually, I even have a bug to fix...

We can do that if you want...

stumpc5 · 2015-09-29T07:17:11Z

comment:14

Replying to @stumpc5:

Replying to @mantepse:

I think it would be better to have the commits added name to json and pull it from there and added name_plural method in a separate ticket. Actually, I even have a bug to fix...

We can do that if you want...

This is now #19307.

sagetrac-git · 2015-09-29T07:21:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`44da776`	`cleaned the statistic name method`
`836f205`	`improved statistic name, added collection name plural, some cosmetic changes as well`
`b95a704`	`Merge branch 't/19307/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface' into t/19296/generating_function_in_findstat_interface`
`cde7b5b`	`removed everything that is now in #19307`

sagetrac-git · 2015-11-10T10:29:40Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1c83fe3`	`tiny fixes`

sagetrac-git · 2015-11-10T10:29:40Z

Changed commit from 72877fa to 1c83fe3

mantepse · 2015-11-10T10:32:04Z

comment:103

I'm giving the parts Christian wrote positive review.

mantepse · 2015-11-10T11:24:39Z

Changed author from Christian Stump to Christian Stump, Martin Rubey

mantepse · 2015-11-10T11:24:39Z

Changed reviewer from Martin Rubey to Martin Rubey, Christian Stump

stumpc5 · 2015-11-10T13:56:08Z

comment:105

looks good to me, and the patchbot is happy...

jdemeyer · 2015-11-10T15:06:35Z

comment:106

This is silly:

try:
    assert foo
except AssertionError:
    raise ValueError(...)

it would be much better to write this is

if not foo:
    raise ValueError(...)

but really, I think you also want to catch TypeError from the depth = int(depth) call.

You should also add doctests for these bad inputs.

sagetrac-git · 2015-11-11T07:35:07Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4620683`	`Merge branch 'develop' of git://github.com/sagemath/sage into t/19296/generating_function_in_findstat_interface`
`fd221b7`	`better argument checking due to jdemeyer`

sagetrac-git · 2015-11-11T07:35:07Z

Changed commit from 1c83fe3 to fd221b7

mantepse · 2015-11-11T07:36:44Z

comment:108

Do you like this version better? (I want to keep the argument checking of depth short and as one entity, that's why I did it this way.)

jdemeyer · 2015-11-11T16:53:01Z

comment:110

Fine for me.

Please remember that you should never use except:, as it is usually the wrong thing to do (it also catches KeyboardInterrupt for example).

vbraun · 2015-11-12T00:15:52Z

comment:111

Doctests must run without network access

sage -t --long src/sage/databases/findstat.py
**********************************************************************
File "src/sage/databases/findstat.py", line 486, in sage.databases.findstat.FindStat.__call__
Failed example:
    findstat("Permutations", 1)
Expected:
    Traceback (most recent call last):
    ...
    ValueError: The given arguments, Permutations and 1, cannot be used for a FindStat search.
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.databases.findstat.FindStat.__call__[3]>", line 1, in <module>
        findstat("Permutations", Integer(1))
      File "sage/misc/lazy_import.pyx", line 383, in sage.misc.lazy_import.LazyImport.__call__ (/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/misc/lazy_import.c:3593)
        return self._get_object()(*args, **kwds)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/databases/findstat.py", line 613, in __call__
        (collection, to_str) = get_collection(None, query_1)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/databases/findstat.py", line 515, in get_collection
        collection = FindStatCollection(element)
      File "sage/misc/classcall_metaclass.pyx", line 326, in sage.misc.classcall_metaclass.ClasscallMetaclass.__call__ (/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/misc/classcall_metaclass.c:1239)
        return cls.classcall(cls, *args, **kwds)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/databases/findstat.py", line 1861, in __classcall_private__
        return FindStatCollections()(entry)
      File "sage/misc/classcall_metaclass.pyx", line 326, in sage.misc.classcall_metaclass.ClasscallMetaclass.__call__ (/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/misc/classcall_metaclass.c:1239)
        return cls.classcall(cls, *args, **kwds)
      File "sage/misc/cachefunc.pyx", line 1304, in sage.misc.cachefunc.WeakCachedFunction.__call__ (/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/misc/cachefunc.c:8470)
        w = self.f(*args, **kwds)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/structure/unique_representation.py", line 1021, in __classcall__
        instance = typecall(cls, *args, **options)
      File "sage/misc/classcall_metaclass.pyx", line 493, in sage.misc.classcall_metaclass.typecall (/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/misc/classcall_metaclass.c:1665)
        return (<PyTypeObject*>type).tp_call(cls, args, kwds)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/databases/findstat.py", line 2357, in __init__
        for j in json.load(urlopen(FINDSTAT_URL_DOWNLOADS_COLLECTIONS)):
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 154, in urlopen
        return opener.open(url, data, timeout)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 431, in open
        response = self._open(req, data)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 449, in _open
        '_open', req)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 409, in _call_chain
        result = func(*args)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 1227, in http_open
        return self.do_open(httplib.HTTPConnection, req)
      File "/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python/urllib2.py", line 1197, in do_open
        raise URLError(err)
    URLError: <urlopen error [Errno 110] Connection timed out>
**********************************************************************
1 item had failures:
   1 of   6 in sage.databases.findstat.FindStat.__call__
    [54 tests, 1 failure, 127.29 s]

sagetrac-git · 2015-11-12T07:35:00Z

Changed commit from fd221b7 to 00dc9e5

sagetrac-git · 2015-11-12T07:35:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`04162f7`	`Merge branch 'develop' of git://github.com/sagemath/sage into t/19296/generating_function_in_findstat_interface`
`00dc9e5`	`Merge branch 'u/mantepse/generating_function_in_findstat_interface' of git://trac.sagemath.org/sage into t/19296/generating_function_in_findstat_interface`

sagetrac-git · 2015-11-12T07:35:42Z

Changed commit from 00dc9e5 to 15ec356

sagetrac-git · 2015-11-12T07:35:42Z

Branch pushed to git repo; I updated commit sha1. New commits:

`15ec356`	`fix test thanks to vbraun`

mantepse · 2015-11-12T07:36:35Z

comment:114

Sorry about that, fixed.

vbraun · 2015-11-12T22:44:28Z

Changed branch from u/mantepse/generating_function_in_findstat_interface to 15ec356

stumpc5 added this to the sage-6.9 milestone Sep 26, 2015

stumpc5 added the p: major / 3 label Sep 26, 2015

This comment has been minimized.

Sign in to view

stumpc5 added the t: enhancement label Sep 26, 2015

stumpc5 added s: positive review and removed s: needs review labels Nov 10, 2015

jdemeyer added s: needs work and removed s: positive review labels Nov 10, 2015

mantepse added s: positive review and removed s: needs work labels Nov 11, 2015

vbraun added s: needs work and removed s: positive review labels Nov 12, 2015

mantepse added s: positive review and removed s: needs work labels Nov 12, 2015

vbraun removed the s: positive review label Nov 12, 2015

vbraun closed this as completed in d2fd8ac Nov 12, 2015

Generating function in FindStat interface #19296

Generating function in FindStat interface #19296

Comments

stumpc5 commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

This comment has been minimized.

stumpc5 commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

sagetrac-git mannequin commented Sep 26, 2015

sagetrac-git mannequin commented Sep 26, 2015

stumpc5 commented Sep 26, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 27, 2015

sagetrac-git mannequin commented Sep 28, 2015

sagetrac-git mannequin commented Sep 28, 2015

mantepse commented Sep 28, 2015

stumpc5 commented Sep 29, 2015

stumpc5 commented Sep 29, 2015

stumpc5 commented Sep 29, 2015

sagetrac-git mannequin commented Sep 29, 2015

sagetrac-git mannequin commented Nov 10, 2015

sagetrac-git mannequin commented Nov 10, 2015

mantepse commented Nov 10, 2015

mantepse commented Nov 10, 2015

mantepse commented Nov 10, 2015

stumpc5 commented Nov 10, 2015

jdemeyer commented Nov 10, 2015

sagetrac-git mannequin commented Nov 11, 2015

sagetrac-git mannequin commented Nov 11, 2015

mantepse commented Nov 11, 2015

jdemeyer commented Nov 11, 2015

vbraun commented Nov 12, 2015

sagetrac-git mannequin commented Nov 12, 2015

sagetrac-git mannequin commented Nov 12, 2015

sagetrac-git mannequin commented Nov 12, 2015

sagetrac-git mannequin commented Nov 12, 2015

mantepse commented Nov 12, 2015

vbraun commented Nov 12, 2015