Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Trac #28287: alarm test failure in CombinatorialPolyhedron.f_vector
Ever since the merging of #26887 I get this one test failure: {{{ sage -t --long --warn-long 157.3 src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx ********************************************************************** File "src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx", line 1132, in sage.geometry.polyhedron.combinatorial_polyhedron.base.Com binatorialPolyhedron.f_vector Failed example: try: alarm(0.5) C.f_vector() except: print("alarm!") Expected: alarm! Got: (1, 25, 300, 2300, 12650, 53130, 177100, 480700, 1081575, 2042975, 3268760, 4457400, 5200300, 5200300, 4457400, 3268760, 2042975, 1081575, 480700, 177100, 53130, 12650, 2300, 300, 25, 1) ********************************************************************** 1 item had failures: 1 of 12 in sage.geometry.polyhedron.combinatorial_polyhedron.base.Co mbinatorialPolyhedron.f_vector [324 tests, 1 failure, 6.49 s] }}} It's a minor issue, but I mark the ticket priority as "critical" as this is likely to affect others as well, and constitutes a regression. There's no way to guarantee that 0.5 seconds, or any amount of time really, is short enough to trigger the alarm as soon as the test requires (though if nothing else it should be a shorter time). I did check, to be certain, that lowering the alarm time in this test does cause it to pass for me. But that's no guarantee it won't still fail on an even faster machine. Although, if as [https://trac.sagemath.org/ticket/26887#comment:184 this comment] states, there is no explicit reason for these tests, I would just remove them. URL: https://trac.sagemath.org/28287 Reported by: embray Ticket author(s): Jonathan Kliem Reviewer(s): Erik Bray
- Loading branch information