Skip to content

Commit

Permalink
gh-35079: Remove 'docker' from the names of the Docker images publish…
Browse files Browse the repository at this point in the history
…ed on ghcr.io

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
We shorten the names of the Docker images generated by our portability
tests slightly by removing the redundant word `docker` from it.
<!-- Why is this change required? What problem does it solve? -->
This is done because the previously used names still belong to the old
repository (which is now renamed as sagemath/sage-archive-...), and the
new repository does not have permissions to push new versions there.
This can be changed package by package in the web interface, but there
is no API for doing so and we have over 1000 packages. So instead we
change the naming pattern; the removal of the redundant word is a
welcome side effect.
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [ ] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->

URL: #35079
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Tobias Diez
  • Loading branch information
Release Manager committed Mar 11, 2023
2 parents 2a7b4c9 + 118f756 commit 1aa2370
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=b9a6c30f4f1c828ca611527d104643d8c0b89ed9
md5=37a7a99a528efa8a4eea1beff33985db
cksum=1112286999
sha1=387297d7e488eb9db6de3ceb80e204d2bdedcfdf
md5=21203b7dbe667c4633c98139bb1b51fb
cksum=4016304194
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a822a2132aa0e85069ec8b6efa48ad6db08cc044
96f5cd2fb8aa1a83f1e0ae8112883a64e79031e5
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ commands =
docker-{arm64,armhf}: docker run --rm --privileged multiarch/qemu-user-static:register --reset
docker: bash -c 'if [ x"{env:DOCKER_CONFIG_FILE:}" != x ]; then mkdir -p {envdir}/.docker && ln -sf $(realpath "{env:DOCKER_CONFIG_FILE:}") {envdir}/.docker/; fi'
docker: bash -c 'for docker_target in {env:DOCKER_TARGETS:with-targets}; do \
docker: BUILD_IMAGE_STEM=sage-$(echo {envname} | sed s/-incremental//); \
docker: BUILD_IMAGE_STEM=sage-$(echo {envname} | sed "s/docker-//;s/-incremental//"); \
docker: BUILD_IMAGE=$DOCKER_PUSH_REPOSITORY$BUILD_IMAGE_STEM-$docker_target; \
docker: BUILD_TAG=$(git describe --dirty --always); \
docker: TAG_ARGS=$(for tag in $BUILD_TAG {env:EXTRA_DOCKER_TAGS:}; do echo --tag $BUILD_IMAGE:$tag; done); \
Expand Down

0 comments on commit 1aa2370

Please sign in to comment.